Bug 115749

Summary: [BlackBerry] Increase the padding size for caret based scrolling.
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated Patch
none
Another updated patch none

Mike Fenton
Reported 2013-05-07 12:38:53 PDT
Reduce the number of scrolls required.
Attachments
Patch (3.62 KB, patch)
2013-05-07 12:40 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Updated Patch (3.34 KB, patch)
2013-05-07 12:47 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Another updated patch (3.36 KB, patch)
2013-05-07 12:48 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2013-05-07 12:40:20 PDT
Created attachment 200959 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-07 12:42:26 PDT
Attachment 200959 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp']" exit_code: 1 Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1372: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mike Fenton
Comment 3 2013-05-07 12:47:29 PDT
Created attachment 200962 [details] Updated Patch
WebKit Commit Bot
Comment 4 2013-05-07 12:48:55 PDT
Attachment 200962 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp']" exit_code: 1 Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1372: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1373: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1374: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1375: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mike Fenton
Comment 5 2013-05-07 12:48:56 PDT
Created attachment 200963 [details] Another updated patch
Rob Buis
Comment 6 2013-05-07 13:02:04 PDT
Comment on attachment 200963 [details] Another updated patch LGTM.
WebKit Commit Bot
Comment 7 2013-05-07 13:29:18 PDT
Comment on attachment 200963 [details] Another updated patch Clearing flags on attachment: 200963 Committed r149689: <http://trac.webkit.org/changeset/149689>
WebKit Commit Bot
Comment 8 2013-05-07 13:29:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.