| Summary: | [BlackBerry] Increase the padding size for caret based scrolling. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Fenton <mifenton> | ||||||||
| Component: | WebKit BlackBerry | Assignee: | Mike Fenton <mifenton> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mike Fenton
2013-05-07 12:38:53 PDT
Created attachment 200959 [details]
Patch
Attachment 200959 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1372: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 200962 [details]
Updated Patch
Attachment 200962 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1372: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1373: Tab found; better to use spaces [whitespace/tab] [1]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1374: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1375: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 200963 [details]
Another updated patch
Comment on attachment 200963 [details]
Another updated patch
LGTM.
Comment on attachment 200963 [details] Another updated patch Clearing flags on attachment: 200963 Committed r149689: <http://trac.webkit.org/changeset/149689> All reviewed patches have been landed. Closing bug. |