Bug 115738

Summary:

Clean up KeyframeValueList and related classes

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, luiz, menard, noam, philn, rego+ews, simon.fraser, webkit-ews, xan.lopez, zeno

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

Anders Carlsson

Reported 2013-05-07 10:49:21 PDT

Clean up KeyframeValueList and related classes

Attachments
Patch (37.46 KB, patch) 2013-05-07 10:53 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (41.84 KB, patch) 2013-05-07 11:02 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (44.10 KB, patch) 2013-05-07 11:17 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (45.87 KB, patch) 2013-05-07 11:26 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (46.79 KB, patch) 2013-05-07 12:08 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (47.15 KB, patch) 2013-05-07 12:18 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (48.21 KB, patch) 2013-05-07 12:36 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (48.20 KB, patch) 2013-05-07 12:44 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (49.31 KB, patch) 2013-05-07 13:33 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (49.80 KB, patch) 2013-05-07 14:24 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Patch for landing (49.43 KB, patch) 2013-05-07 14:36 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-05-07 10:53:43 PDT

Created attachment 200929 [details] Patch

Early Warning System Bot

Comment 2 2013-05-07 10:58:34 PDT

Comment on attachment 200929 [details] Patch Attachment 200929 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/347183

Early Warning System Bot

Comment 3 2013-05-07 11:00:13 PDT

Comment on attachment 200929 [details] Patch Attachment 200929 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/356096

EFL EWS Bot

Comment 4 2013-05-07 11:00:36 PDT

Comment on attachment 200929 [details] Patch Attachment 200929 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/356097

Anders Carlsson

Comment 5 2013-05-07 11:02:09 PDT

Created attachment 200935 [details] Patch

Early Warning System Bot

Comment 6 2013-05-07 11:13:28 PDT

Comment on attachment 200935 [details] Patch Attachment 200935 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/323089

Anders Carlsson

Comment 7 2013-05-07 11:17:13 PDT

Created attachment 200939 [details] Patch

EFL EWS Bot

Comment 8 2013-05-07 11:22:05 PDT

Comment on attachment 200939 [details] Patch Attachment 200939 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/356107

Early Warning System Bot

Comment 9 2013-05-07 11:23:32 PDT

Comment on attachment 200939 [details] Patch Attachment 200939 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/271127

Early Warning System Bot

Comment 10 2013-05-07 11:25:01 PDT

Comment on attachment 200939 [details] Patch Attachment 200939 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/355139

Anders Carlsson

Comment 11 2013-05-07 11:26:47 PDT

Created attachment 200945 [details] Patch

Early Warning System Bot

Comment 12 2013-05-07 11:37:56 PDT

Comment on attachment 200945 [details] Patch Attachment 200945 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/338137

EFL EWS Bot

Comment 13 2013-05-07 11:41:10 PDT

Comment on attachment 200945 [details] Patch Attachment 200945 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/336168

Early Warning System Bot

Comment 14 2013-05-07 11:42:50 PDT

Comment on attachment 200945 [details] Patch Attachment 200945 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/359135

EFL EWS Bot

Comment 15 2013-05-07 11:49:19 PDT

Comment on attachment 200945 [details] Patch Attachment 200945 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/359139

Anders Carlsson

Comment 16 2013-05-07 12:08:32 PDT

Created attachment 200954 [details] Patch

Early Warning System Bot

Comment 17 2013-05-07 12:13:14 PDT

Comment on attachment 200954 [details] Patch Attachment 200954 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/355154

EFL EWS Bot

Comment 18 2013-05-07 12:13:24 PDT

Comment on attachment 200954 [details] Patch Attachment 200954 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/347213

Early Warning System Bot

Comment 19 2013-05-07 12:14:12 PDT

Comment on attachment 200954 [details] Patch Attachment 200954 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/347211

Anders Carlsson

Comment 20 2013-05-07 12:18:24 PDT

Created attachment 200956 [details] Patch

Early Warning System Bot

Comment 21 2013-05-07 12:24:51 PDT

Comment on attachment 200956 [details] Patch Attachment 200956 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/271150

Early Warning System Bot

Comment 22 2013-05-07 12:25:36 PDT

Comment on attachment 200956 [details] Patch Attachment 200956 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/355159

EFL EWS Bot

Comment 23 2013-05-07 12:26:40 PDT

Comment on attachment 200956 [details] Patch Attachment 200956 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/442097

Anders Carlsson

Comment 24 2013-05-07 12:36:33 PDT

Created attachment 200958 [details] Patch

EFL EWS Bot

Comment 25 2013-05-07 12:42:35 PDT

Comment on attachment 200958 [details] Patch Attachment 200958 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/336191

Anders Carlsson

Comment 26 2013-05-07 12:44:39 PDT

Created attachment 200960 [details] Patch

Early Warning System Bot

Comment 27 2013-05-07 12:59:33 PDT

Comment on attachment 200960 [details] Patch Attachment 200960 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/323133

Simon Fraser (smfr)

Comment 28 2013-05-07 13:04:48 PDT

Comment on attachment 200960 [details] Patch r=me for this and any future version of this patch.

Anders Carlsson

Comment 29 2013-05-07 13:33:38 PDT

Created attachment 200964 [details] Patch

Noam Rosenthal

Comment 30 2013-05-07 13:36:26 PDT

Next time let me know and I'll do the coordinated graphics related part... takes me a minute when I can compile it :)

Early Warning System Bot

Comment 31 2013-05-07 13:39:29 PDT

Comment on attachment 200964 [details] Patch Attachment 200964 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/266162

Noam Rosenthal

Comment 32 2013-05-07 14:24:26 PDT

Created attachment 200977 [details] Patch

Noam Rosenthal

Comment 33 2013-05-07 14:36:33 PDT

Created attachment 200978 [details] Patch for landing

WebKit Commit Bot

Comment 34 2013-05-07 15:03:15 PDT

Comment on attachment 200978 [details] Patch for landing Clearing flags on attachment: 200978 Committed r149694: <http://trac.webkit.org/changeset/149694>

WebKit Commit Bot

Comment 35 2013-05-07 15:03:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.