Summary: | [Automake] Pass --no-demangle to the linker by default to get the mangled symbols | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gns | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 96514 | ||||||
Attachments: |
|
Description
Zan Dobersek
2013-05-07 09:38:05 PDT
Created attachment 200921 [details]
Patch
Comment on attachment 200921 [details]
Patch
LGTM, except I'm worry it works in our jhbuilt environments just because it sets LDFLAGS, so your += works. If you could make sure it also works when no LDFLAGS are set in the environment, that would be great.
It also works with no LDFLAGS present in the environment. Thanks for the review! Comment on attachment 200921 [details] Patch Clearing flags on attachment: 200921 Committed r149714: <http://trac.webkit.org/changeset/149714> All reviewed patches have been landed. Closing bug. |