Bug 115732

Summary: [Automake] Pass --no-demangle to the linker by default to get the mangled symbols
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: gns
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96514    
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2013-05-07 09:38:05 PDT
[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
Comment 1 Zan Dobersek 2013-05-07 09:47:39 PDT
Created attachment 200921 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-05-07 15:18:12 PDT
Comment on attachment 200921 [details]
Patch

LGTM, except I'm worry it works in our jhbuilt environments just because it sets LDFLAGS, so your += works. If you could make sure it also works when no LDFLAGS are set in the environment, that would be great.
Comment 3 Zan Dobersek 2013-05-07 23:59:41 PDT
It also works with no LDFLAGS present in the environment. Thanks for the review!
Comment 4 Zan Dobersek 2013-05-08 00:03:06 PDT
Comment on attachment 200921 [details]
Patch

Clearing flags on attachment: 200921

Committed r149714: <http://trac.webkit.org/changeset/149714>
Comment 5 Zan Dobersek 2013-05-08 00:03:13 PDT
All reviewed patches have been landed.  Closing bug.