Bug 115723

Summary:

Make optional arguments in CanvasRenderingContext2D match the spec.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Canvas

Assignee:

Dongseong Hwang <dongseong.hwang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, esprehn+autocc, rniwa, syoichi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

82791

Attachments:

Description	Flags
Patch	dino: review+, commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch to land	none

Description Dongseong Hwang 2013-05-07 07:03:19 PDT

WebKit r98985 set many arguments optional although the canvas spec[1] does not 
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec. 

[1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

Comment 1 Dongseong Hwang 2013-05-07 09:10:50 PDT

Created attachment 200911 [details]
Patch

Comment 2 Dongseong Hwang 2013-05-07 09:11:48 PDT

I submitted this patch in Blink also: https://codereview.chromium.org/14654002/

Comment 3 Dongseong Hwang 2013-05-07 10:38:16 PDT

In Blink, this patch is landed.

Comment 4 Dean Jackson 2013-05-07 10:41:40 PDT

Comment on attachment 200911 [details]
Patch

Thanks!

Comment 5 Dongseong Hwang 2013-05-07 10:49:17 PDT

Thank you too! :)

Comment 6 WebKit Commit Bot 2013-05-07 11:21:46 PDT

Comment on attachment 200911 [details]
Patch

Rejecting attachment 200911 [details] from commit-queue.

New failing tests:
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
Full output: http://webkit-queues.appspot.com/results/379230

Comment 7 WebKit Commit Bot 2013-05-07 11:21:48 PDT

Created attachment 200943 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

Comment 8 Build Bot 2013-05-07 14:47:36 PDT

Comment on attachment 200911 [details]
Patch

Attachment 200911 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/350176

New failing tests:
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

Comment 9 Build Bot 2013-05-07 14:47:38 PDT

Created attachment 200979 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

Comment 10 Build Bot 2013-05-07 15:05:13 PDT

Comment on attachment 200911 [details]
Patch

Attachment 200911 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/356177

New failing tests:
media/video-zoom.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

Comment 11 Build Bot 2013-05-07 15:05:16 PDT

Created attachment 200983 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

Comment 12 Dongseong Hwang 2013-05-07 22:18:19 PDT

Created attachment 201030 [details]
Patch to land

Comment 13 Dongseong Hwang 2013-05-07 22:19:31 PDT

Comment on attachment 201030 [details]
Patch to land

I missed inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
I assumed all canvas tests are in canvas and fast/canvas.

Comment 14 WebKit Commit Bot 2013-05-08 01:54:38 PDT

Comment on attachment 201030 [details]
Patch to land

Clearing flags on attachment: 201030

Committed r149723: <http://trac.webkit.org/changeset/149723>

Comment 15 WebKit Commit Bot 2013-05-08 01:54:41 PDT

All reviewed patches have been landed.  Closing bug.