Bug 115713

Summary: [EFL] Refactor ewk_view_scroll to remove internal structure.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gyuyoung.kim: review+

Ryuan Choi
Reported 2013-05-06 23:26:07 PDT
After removed c-ism from WebKit/Efl, we don't need to keep the internal structures like Ewk_Scroll_Request. It's just used to pass scrollRect and delta to c files.
Attachments
Patch (20.60 KB, patch)
2013-05-06 23:32 PDT, Ryuan Choi 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-05-06 23:32:33 PDT
Created attachment 200876 [details] Patch
Gyuyoung Kim
Comment 2 2013-06-13 00:45:28 PDT
Comment on attachment 200876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200876&action=review Looks fine refactoring. r=me. > Source/WebKit/efl/ChangeLog:8 > + After removed c-ism from WebKit/Efl, There are no reason to keep internal are -> is ?
Ryuan Choi
Comment 3 2013-06-13 00:52:56 PDT
Committed r151540: <http://trac.webkit.org/changeset/151540>
Ryuan Choi
Comment 4 2013-06-13 00:53:23 PDT
(In reply to comment #2) > (From update of attachment 200876 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200876&action=review > > Looks fine refactoring. r=me. > > > Source/WebKit/efl/ChangeLog:8 > > + After removed c-ism from WebKit/Efl, There are no reason to keep internal > > are -> is ? Thank you. Landed after fixed.
Note You need to log in before you can comment on or make changes to this bug.