Bug 115683

Summary:

Remove some unnecessary soft linking in NetworkProcess

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch v1	sam: review+
Patch v2 - Include headers when available, and fix a bug 149651 introduced.	dino: review+

Brady Eidson

Reported 2013-05-06 16:52:48 PDT

Remove some unnecessary soft linking in NetworkProcess. These can be replaced with forward declarations. Some of theIn radar <rdar://problem/13821779>

Attachments
Patch v1 (5.45 KB, patch) 2013-05-06 16:55 PDT, Brady Eidson	sam: review+	Details Formatted Diff Diff
Patch v2 - Include headers when available, and fix a bug 149651 introduced. (3.06 KB, patch) 2013-05-07 09:27 PDT, Brady Eidson	dino: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2013-05-06 16:55:59 PDT

Created attachment 200856 [details] Patch v1

Brady Eidson

Comment 2 2013-05-06 17:04:39 PDT

http://trac.webkit.org/changeset/149651

Alexey Proskuryakov

Comment 3 2013-05-06 20:17:56 PDT

One thing we are trying to do more now is conditionally include internal headers. That way, compiler will tell us if prototypes change in the future.

Brady Eidson

Comment 4 2013-05-07 08:59:50 PDT

(In reply to comment #3) > One thing we are trying to do more now is conditionally include internal headers. That way, compiler will tell us if prototypes change in the future. Yes, Mark mentioned this to use last night. It appears that it's been done in precisely two locations, and you were the first back in February - Should've shared it with us then! :)

Brady Eidson

Comment 5 2013-05-07 09:24:06 PDT

...and doing this revealed a terrible bug with last nights patch - The exact type of bug this trick is meant to catch! Followup coming...

Brady Eidson

Comment 6 2013-05-07 09:27:48 PDT

Created attachment 200917 [details] Patch v2 - Include headers when available, and fix a bug 149651 introduced.

Andreas Kling

Comment 7 2013-05-07 10:06:46 PDT

Comment on attachment 200917 [details] Patch v2 - Include headers when available, and fix a bug 149651 introduced. I'm here for the owner sign-off!

Brady Eidson

Comment 8 2013-05-07 10:09:50 PDT

http://trac.webkit.org/changeset/149678

Note You need to log in before you can comment on or make changes to this bug.