Summary: | Hittest finds the truncated text instead of the floating input, when the input is clicked. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, hyatt, tonikitoo | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
zalan
2013-05-06 14:11:42 PDT
Created attachment 200808 [details]
reduced test case
1. We need to use the m_truncation at InlineTextBox::nodeAtPoint() to make sure truncated text is ignored while hittesting. 2, We need to teach the parent RootInlineBox to be smarter at hittesting (InlineFlowBox::nodeAtPoint()) to figure out that the truncated part. [12:57am] dhyatt: if i were writing this feature from scratch i would probably have let the child elements overflow [12:57am] dhyatt: but shrink the root line [12:57am] dhyatt: might be some reason why i didn't do that though [12:58am] dhyatt: easiest fix at this point is to just hack it then prob [12:58am] dhyatt: painting must just be hacking it [12:58am] dhyatt: so hit testing can too Created attachment 201179 [details]
Patch
will be moving layout test to /fast/css Created attachment 201456 [details]
Patch
Comment on attachment 201456 [details]
Patch
Make a vertical-rl test too.
Created attachment 202237 [details]
Patch
(In reply to comment #8) > (From update of attachment 201456 [details]) > Make a vertical-rl test too. added (best effort). Vertical text truncate bug is tracked here: bug #116413 Created attachment 205277 [details]
Patch
Comment on attachment 205277 [details] Patch Clearing flags on attachment: 205277 Committed r151894: <http://trac.webkit.org/changeset/151894> All reviewed patches have been landed. Closing bug. |