Bug 115649

Summary: [CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115292    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-05-06 08:49:19 PDT
The following test started failing when subpixel layout was disabled for the OSX port (see http://trac.webkit.org/changeset/149224). fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
Attachments
Patch (5.93 KB, patch)
2013-05-07 12:44 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-05-07 12:44:56 PDT
Created attachment 200961 [details] Patch Another correction of a padded shape test that failed when subpixel layout was disabled. This test puts a cross pattern made of five Ahem characters on three lines, within a padded diamond polygon. The left edges of each line depend on the intersection of the padded polygon's edges with the top of each line, which makes predicting the exact values unreliable. So we just verify that the left edges of each line are within a pixel of the ideal value. This change is very similar to the one made for https://bugs.webkit.org/show_bug.cgi?id=115490.
WebKit Commit Bot
Comment 2 2013-05-07 15:53:28 PDT
Comment on attachment 200961 [details] Patch Clearing flags on attachment: 200961 Committed r149699: <http://trac.webkit.org/changeset/149699>
WebKit Commit Bot
Comment 3 2013-05-07 15:53:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.