Bug 115622

Summary:

[BLACKBERRY]clean up load interface in WebPage

Product:

WebKit

Reporter:

xuefeiren <xren>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joenotcharles, mawu, rwlbuis, xren

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
clean up load interface in WebPage	rwlbuis: review+
clean up load interface in WebPage	none
clean up load interface in WebPage	none
clean up load interface in WebPage	commit-queue: commit-queue-
clean up load interface in WebPage	none
clean up load interface in WebPage	none

xuefeiren

Reported 2013-05-05 23:07:23 PDT

Clean up load interface in WebPage internal PR: https://bugzilla.qnx.com/bugzilla/show_bug.cgi?id=315535 internal reviewed by Marry Wu

Attachments
clean up load interface in WebPage (10.36 KB, patch) 2013-05-05 23:27 PDT, xuefeiren	rwlbuis: review+	Details Formatted Diff Diff
clean up load interface in WebPage (10.49 KB, patch) 2013-05-07 18:41 PDT, xuefeiren	no flags	Details Formatted Diff Diff
clean up load interface in WebPage (10.49 KB, patch) 2013-05-07 19:06 PDT, xuefeiren	no flags	Details Formatted Diff Diff
clean up load interface in WebPage (10.36 KB, patch) 2013-05-07 19:08 PDT, xuefeiren	commit-queue: commit-queue-	Details Formatted Diff Diff
clean up load interface in WebPage (20.80 KB, patch) 2013-05-07 19:49 PDT, xuefeiren	no flags	Details Formatted Diff Diff
clean up load interface in WebPage (10.23 KB, patch) 2013-05-07 19:52 PDT, xuefeiren	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

xuefeiren

Comment 1 2013-05-05 23:27:50 PDT

Created attachment 200605 [details] clean up load interface in WebPage clean up load interface in WebPage

Rob Buis

Comment 2 2013-05-07 08:49:17 PDT

Comment on attachment 200605 [details] clean up load interface in WebPage View in context: https://bugs.webkit.org/attachment.cgi?id=200605&action=review Looks good, but please fix the ChangeLog and then ask Charles or Mary to commit. > Source/WebKit/blackberry/ChangeLog:8 > + Internal reviewd by : Marry WU It is reviewed by, and "Mary Wu".

xuefeiren

Comment 3 2013-05-07 18:41:05 PDT

Created attachment 201012 [details] clean up load interface in WebPage commit-queue?

Rob Buis

Comment 4 2013-05-07 18:57:40 PDT

Comment on attachment 201012 [details] clean up load interface in WebPage View in context: https://bugs.webkit.org/attachment.cgi?id=201012&action=review > Source/WebKit/blackberry/ChangeLog:5 > + Reviewed by Rob Buis and Marry Wu. This will probably not work. You should ask Charles, Mary or Ming how to fix it.

xuefeiren

Comment 5 2013-05-07 19:06:55 PDT

Created attachment 201014 [details] clean up load interface in WebPage commit ?

xuefeiren

Comment 6 2013-05-07 19:08:19 PDT

Created attachment 201015 [details] clean up load interface in WebPage commit?

Charles Wei

Comment 7 2013-05-07 19:28:25 PDT

Comment on attachment 201015 [details] clean up load interface in WebPage Commit.

WebKit Commit Bot

Comment 8 2013-05-07 19:30:33 PDT

Comment on attachment 201015 [details] clean up load interface in WebPage Rejecting attachment 201015 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 201015, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patching file Source/WebKit/blackberry/Api/WebPage_p.h patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp Hunk #1 FAILED at 1200. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/377497

xuefeiren

Comment 9 2013-05-07 19:49:16 PDT

Created attachment 201020 [details] clean up load interface in WebPage commit?

xuefeiren

Comment 10 2013-05-07 19:52:48 PDT

Created attachment 201021 [details] clean up load interface in WebPage commit?

Charles Wei

Comment 11 2013-05-07 20:00:46 PDT

Comment on attachment 201021 [details] clean up load interface in WebPage re-commit after rebase to resolve the conflict.

WebKit Commit Bot

Comment 12 2013-05-07 22:07:46 PDT

Comment on attachment 201021 [details] clean up load interface in WebPage Clearing flags on attachment: 201021 Committed r149711: <http://trac.webkit.org/changeset/149711>

WebKit Commit Bot

Comment 13 2013-05-07 22:07:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.