Summary: | [BLACKBERRY]clean up load interface in WebPage | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | xuefeiren <xren> | ||||||||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, joenotcharles, mawu, rwlbuis, xren | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
xuefeiren
2013-05-05 23:07:23 PDT
Created attachment 200605 [details]
clean up load interface in WebPage
clean up load interface in WebPage
Comment on attachment 200605 [details] clean up load interface in WebPage View in context: https://bugs.webkit.org/attachment.cgi?id=200605&action=review Looks good, but please fix the ChangeLog and then ask Charles or Mary to commit. > Source/WebKit/blackberry/ChangeLog:8 > + Internal reviewd by : Marry WU It is reviewed by, and "Mary Wu". Created attachment 201012 [details]
clean up load interface in WebPage
commit-queue?
Comment on attachment 201012 [details] clean up load interface in WebPage View in context: https://bugs.webkit.org/attachment.cgi?id=201012&action=review > Source/WebKit/blackberry/ChangeLog:5 > + Reviewed by Rob Buis and Marry Wu. This will probably not work. You should ask Charles, Mary or Ming how to fix it. Created attachment 201014 [details]
clean up load interface in WebPage
commit ?
Created attachment 201015 [details]
clean up load interface in WebPage
commit?
Comment on attachment 201015 [details]
clean up load interface in WebPage
Commit.
Comment on attachment 201015 [details] clean up load interface in WebPage Rejecting attachment 201015 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 201015, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patching file Source/WebKit/blackberry/Api/WebPage_p.h patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp Hunk #1 FAILED at 1200. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/377497 Created attachment 201020 [details]
clean up load interface in WebPage
commit?
Created attachment 201021 [details]
clean up load interface in WebPage
commit?
Comment on attachment 201021 [details]
clean up load interface in WebPage
re-commit after rebase to resolve the conflict.
Comment on attachment 201021 [details] clean up load interface in WebPage Clearing flags on attachment: 201021 Committed r149711: <http://trac.webkit.org/changeset/149711> All reviewed patches have been landed. Closing bug. |