| Summary: | Update code generators to handle a new JavaScript file for snapshotted plug-ins | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2013-05-04 13:58:06 PDT
Created attachment 200542 [details]
Patch
Comment on attachment 200542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200542&action=review > Source/WebCore/ChangeLog:22 > + * CMakeLists.txt: > + * DerivedSources.cpp: > + * DerivedSources.make: > + * DerivedSources.pri: > + * GNUmakefile.am: > + * GNUmakefile.list.am: > + * Resources/plugIns.js: Added. > + * WebCore.vcproj/WebCore.vcproj: > + * WebCore.vcxproj/WebCore.vcxproj: > + * WebCore.vcxproj/WebCore.vcxproj.filters: > + * WebCore.xcodeproj/project.pbxproj: You should at least give quick descriptions of what you're changing here, especially when you're adding new rule blocks. Comment on attachment 200542 [details] Patch Rejecting attachment 200542 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 200542, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patching file Source/WebCore/GNUmakefile.list.am Hunk #1 succeeded at 891 (offset -2 lines). patch: **** Only garbage was found in the patch input. fatal: pathspec 'Source/WebCore/Resources/plugIns.js' did not match any files Failed to git add Source/WebCore/Resources/plugIns.js. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 448. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/357795 Created attachment 200543 [details]
Patch for landing
Comment on attachment 200543 [details] Patch for landing Rejecting attachment 200543 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 200543, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urce/WebCore/DerivedSources.pri patching file Source/WebCore/GNUmakefile.am patching file Source/WebCore/GNUmakefile.list.am patch: **** Only garbage was found in the patch input. fatal: pathspec 'Source/WebCore/Resources/plugIns.js' did not match any files Failed to git add Source/WebCore/Resources/plugIns.js. at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 448. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/384844 Created attachment 200544 [details]
Patch for landing
Comment on attachment 200544 [details] Patch for landing Clearing flags on attachment: 200544 Committed r149569: <http://trac.webkit.org/changeset/149569> All reviewed patches have been landed. Closing bug. This broke the Windows build: 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(2) : error C2466: cannot allocate an array of constant size 0 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(3) : error C2466: cannot allocate an array of constant size 0 (In reply to comment #9) > This broke the Windows build: > > 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(2) : error C2466: cannot allocate an array of constant size 0 > 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\obj\WebCore\DerivedSources\PlugInsResourcesData.cpp(3) : error C2466: cannot allocate an array of constant size 0 The patch for https://bugs.webkit.org/show_bug.cgi?id=115548 will fix this. I will land this momentarily. |