| Summary: | [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||
| Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, gns, jer.noble, menard, mrobinson, philn, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Xabier Rodríguez Calvar
2013-05-03 14:03:15 PDT
Created attachment 200468 [details]
Patch
Fixes the cadebug category for MediaPlayerPrivatteGStreamerBase.
Comment on attachment 200468 [details]
Patch
Oh I didn't know the debug category was declared twice. I think it would make more sense to declare it once in the Base header and as extern.
If that's possible of course :) (In reply to comment #2) > (From update of attachment 200468 [details]) > Oh I didn't know the debug category was declared twice. I think it would make more sense to declare it once in the Base header and as extern. The problem of that is the types, and exporting more things like this debug thing is not a very good idea. Base.h file is used in other places. We could create another common .h that we would include in both cpp file, but I think that's overkilling. Comment on attachment 200468 [details]
Patch
Oh sorry I misread the patch in the first place. This actually looks good to me :)
Comment on attachment 200468 [details] Patch Clearing flags on attachment: 200468 Committed r149543: <http://trac.webkit.org/changeset/149543> All reviewed patches have been landed. Closing bug. |