Bug 115574

Summary:

Crash using new WKBundlePageSetHeaderBanner() API to set a banner to null

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, benjamin, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Beth Dakin 2013-05-03 13:55:39 PDT

The new WKBundlePageSetHeaderBanner does not correctly handle the null banner case. Patch forthcoming.

<rdar://problem/13798364>

Comment 1 Beth Dakin 2013-05-03 13:57:51 PDT

Created attachment 200466 [details]
Patch

Comment 2 Benjamin Poulain 2013-05-03 15:58:15 PDT

Comment on attachment 200466 [details]
Patch

No API tests?

Comment 3 Beth Dakin 2013-05-04 11:44:09 PDT

(In reply to comment #2)
> (From update of attachment 200466 [details])
> No API tests?

You're right; Sam and I should add API tests for this feature. Up until when Sam added the hit testing stuff to the API (which led to this crash), most of the interesting work was happening down in WebCore and we have been testing it with Internals.setHeaderHeight and Internals.setFooterHeight.

Comment 4 Beth Dakin 2013-05-04 11:46:05 PDT

http://trac.webkit.org/changeset/149561