Bug 115568

Summary: Simplify the #ifdefs in GraphicsContext3D.h
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: PlatformAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, d-r
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Move the no-op implementations to GraphicsContext3D.h
none
Move the no-op implementations to GraphicsContext3D.h benjamin: review+

Martin Robinson
Reported 2013-05-03 11:58:47 PDT
The #ifdefs in the header are overwhelming on first glance and befuddling on the second.
Attachments
Patch (4.71 KB, patch)
2013-05-03 12:03 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Move the no-op implementations to GraphicsContext3D.h (5.56 KB, patch)
2013-05-03 12:19 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Move the no-op implementations to GraphicsContext3D.h (5.44 KB, patch)
2013-05-03 12:21 PDT, Martin Robinson 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-05-03 12:03:47 PDT
Created attachment 200452 [details] Patch
Martin Robinson
Comment 2 2013-05-03 12:19:24 PDT
Created attachment 200456 [details] Move the no-op implementations to GraphicsContext3D.h
Martin Robinson
Comment 3 2013-05-03 12:21:05 PDT
Created attachment 200457 [details] Move the no-op implementations to GraphicsContext3D.h
Benjamin Poulain
Comment 4 2013-05-03 15:57:10 PDT
Comment on attachment 200457 [details] Move the no-op implementations to GraphicsContext3D.h View in context: https://bugs.webkit.org/attachment.cgi?id=200457&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1474 > +#if !PLATFORM(BLACKBERRY) && !PLATFORM(QT) && !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC) Isn't this just PLATFORM(WINDOWS)?
Martin Robinson
Comment 5 2013-05-03 17:08:38 PDT
(In reply to comment #4) > (From update of attachment 200457 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200457&action=review > > > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1474 > > +#if !PLATFORM(BLACKBERRY) && !PLATFORM(QT) && !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC) > > Isn't this just PLATFORM(WINDOWS)? Sorry. Just saw this comment. Now that Chromium is gone we can probably simplify all these #ifdefs to PLATFORM(WINDOWS). I'll try to submit another patch and put it up against the EWS.
Martin Robinson
Comment 6 2013-05-03 17:11:04 PDT
Committed r149546: <http://trac.webkit.org/changeset/149546>
Note You need to log in before you can comment on or make changes to this bug.