| Summary: | Simplify the #ifdefs in GraphicsContext3D.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
| Component: | Platform | Assignee: | Martin Robinson <mrobinson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, dino, d-r | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Martin Robinson
2013-05-03 11:58:47 PDT
Created attachment 200452 [details]
Patch
Created attachment 200456 [details]
Move the no-op implementations to GraphicsContext3D.h
Created attachment 200457 [details]
Move the no-op implementations to GraphicsContext3D.h
Comment on attachment 200457 [details] Move the no-op implementations to GraphicsContext3D.h View in context: https://bugs.webkit.org/attachment.cgi?id=200457&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1474 > +#if !PLATFORM(BLACKBERRY) && !PLATFORM(QT) && !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC) Isn't this just PLATFORM(WINDOWS)? (In reply to comment #4) > (From update of attachment 200457 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200457&action=review > > > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1474 > > +#if !PLATFORM(BLACKBERRY) && !PLATFORM(QT) && !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC) > > Isn't this just PLATFORM(WINDOWS)? Sorry. Just saw this comment. Now that Chromium is gone we can probably simplify all these #ifdefs to PLATFORM(WINDOWS). I'll try to submit another patch and put it up against the EWS. Committed r149546: <http://trac.webkit.org/changeset/149546> |