Bug 115551

Summary: [Qt] Build with --video-track fails because String(AtomicString) is ambiguous
Product: WebKit Reporter: Brendan Long <b.long>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: b.long, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, pnormand
Priority: P2 Keywords: PlatformOnly, Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fix QtWebKitBuild with --video-track none

Brendan Long
Reported 2013-05-03 09:33:58 PDT
[Qt] Build with --video-track fails because String(AtomicString) is ambiguous
Attachments
Fix QtWebKitBuild with --video-track (1.80 KB, patch)
2013-05-03 09:35 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brendan Long
Comment 1 2013-05-03 09:35:33 PDT
Created attachment 200419 [details] Fix QtWebKitBuild with --video-track
Brendan Long
Comment 2 2013-05-03 09:37:37 PDT
I'm using qt5-tools (https://github.com/ossy-szeged/qt5-tools) to build Qt5, which may be out of date (2 months since last commit), but this error only shows up if I build with --video-track. Full error message: /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp: In member function 'void WebCore::HTMLMediaElement::configureTextTrackGroup(const WebCore::HTMLMediaElement::TrackGroup&)': /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:142: note: candidates are: /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&) /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&) /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: error: call of overloaded 'String(WTF::AtomicString)' is ambiguous /home/blong/workspace/webkit/Source/WebCore/html/HTMLMediaElement.cpp:3210:187: note: candidates are: /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:431:44: note: WTF::String::String(const QString&) /home/blong/workspace/webkit/Source/WTF/wtf/text/WTFString.h:98:7: note: WTF::String::String(const WTF::String&)
Philippe Normand
Comment 3 2013-05-03 11:46:15 PDT
Why is this not working only in Qt? A change to cross-port code to satisfy a single port is suspect to me.
Brendan Long
Comment 4 2013-05-03 12:33:15 PDT
I'm trying to build against a different version of Qt to see if this is just a weird issue with the versions not matching up.
Brendan Long
Comment 5 2013-05-03 15:08:37 PDT
I get this when building against Qt5 master also, so it seems to be a real problem. It seems like making String(AtomicString) not ambiguous would be nice, but I'm not sure if there's a reasonable way to do that.
Benjamin Poulain
Comment 6 2013-05-03 16:20:29 PDT
Comment on attachment 200419 [details] Fix QtWebKitBuild with --video-track Not sure why would that constructor would be ambiguous, but the patch looks fine.
WebKit Commit Bot
Comment 7 2013-05-03 16:43:51 PDT
Comment on attachment 200419 [details] Fix QtWebKitBuild with --video-track Clearing flags on attachment: 200419 Committed r149544: <http://trac.webkit.org/changeset/149544>
WebKit Commit Bot
Comment 8 2013-05-03 16:43:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.