Bug 115534

Summary: [CSSRegions] Improve hit testing for empty regions
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, hyatt, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch for landing none

Mihnea Ovidenie
Reported 2013-05-02 16:27:57 PDT
WebKit bug https://bugs.webkit.org/show_bug.cgi?id=107752 provided a way to fix incorrect selection of content in HTML document when clicking inside an empty region. I want to address the follow up comment from David Hyatt and improve the hit testing code.
Attachments
Patch (3.17 KB, patch)
2013-05-02 16:37 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch 2 (4.49 KB, patch)
2013-05-10 23:18 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.69 KB, patch)
2013-05-14 09:24 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2013-05-02 16:37:33 PDT
Created attachment 200369 [details] Patch
Dave Hyatt
Comment 2 2013-05-10 13:26:38 PDT
Comment on attachment 200369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200369&action=review > Source/WebCore/rendering/RenderObject.cpp:2624 > - if (hitTestFilter != HitTestDescendants && !inside) > + if (hitTestFilter != HitTestDescendants && !inside && !isRenderFlowThread()) I wonder if it would be cleaner to subclass nodeAtPoint for RenderFlowThread and have it return false always if HitTestBlockBackground is the flag?
Mihnea Ovidenie
Comment 3 2013-05-10 23:18:32 PDT
Created attachment 201449 [details] Patch 2 Use David's suggestion as the hittesting code is better contained in RFT class.
Dave Hyatt
Comment 4 2013-05-14 08:10:29 PDT
Comment on attachment 201449 [details] Patch 2 r=me
Mihnea Ovidenie
Comment 5 2013-05-14 09:24:22 PDT
Created attachment 201725 [details] Patch for landing
WebKit Commit Bot
Comment 6 2013-05-14 10:55:03 PDT
Comment on attachment 201725 [details] Patch for landing Clearing flags on attachment: 201725 Committed r150078: <http://trac.webkit.org/changeset/150078>
WebKit Commit Bot
Comment 7 2013-05-14 10:55:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.