Bug 115520

Summary: [WK2] Non-ASCII downloaded file names are garbled when using NetworkProcess
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix darin: review+

Alexey Proskuryakov
Reported 2013-05-02 11:36:44 PDT
responseContentDispositionEncodingFallbackArray is not sent over IPC. <rdar://problem/13740375>
Attachments
proposed fix (9.15 KB, patch)
2013-05-02 11:46 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-05-02 11:46:54 PDT
Created attachment 200325 [details] proposed fix
Darin Adler
Comment 2 2013-05-02 11:52:06 PDT
Comment on attachment 200325 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=200325&action=review > Source/WebCore/platform/network/ResourceRequestBase.h:114 > + const Vector<String> responseContentDispositionEncodingFallbackArray() const { return m_responseContentDispositionEncodingFallbackArray; } The const here in const Vector<String> is not needed or helpful. Unless maybe you wanted to return const& to avoid copying. > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:63 > + encoder << resourceRequest.responseContentDispositionEncodingFallbackArray(); Do we have to bump a version number when we do things like this?
Alexey Proskuryakov
Comment 3 2013-05-02 11:59:55 PDT
> Unless maybe you wanted to return const& to avoid copying. Oops, yes. > Do we have to bump a version number when we do things like this? Not here, this serialization is for IPC only, and is not persistent.
Alexey Proskuryakov
Comment 4 2013-05-02 12:25:53 PDT
Committed <http://trac.webkit.org/r149491>.
Note You need to log in before you can comment on or make changes to this bug.