| Summary: | [WK2] Non-ASCII downloaded file names are garbled when using NetworkProcess | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2013-05-02 11:36:44 PDT
Created attachment 200325 [details]
proposed fix
Comment on attachment 200325 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=200325&action=review > Source/WebCore/platform/network/ResourceRequestBase.h:114 > + const Vector<String> responseContentDispositionEncodingFallbackArray() const { return m_responseContentDispositionEncodingFallbackArray; } The const here in const Vector<String> is not needed or helpful. Unless maybe you wanted to return const& to avoid copying. > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:63 > + encoder << resourceRequest.responseContentDispositionEncodingFallbackArray(); Do we have to bump a version number when we do things like this? > Unless maybe you wanted to return const& to avoid copying. Oops, yes. > Do we have to bump a version number when we do things like this? Not here, this serialization is for IPC only, and is not persistent. Committed <http://trac.webkit.org/r149491>. |