Bug 115519

Summary:

Make BloomFilter Fast-Allocated

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bfulgham, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Brent Fulgham

Reported 2013-05-02 11:31:23 PDT

While tracking down some memory allocation problems on Windows (see Bug 115130), I noticed that BloomFilter did not use the WTF_MAKE_FAST_ALLOCATED macro. Under Windows, the global replacement of operator new/delete should cause this to be fast allocated, but in practice results in a mismatch (allocating with system new, deallocating with fastFree). Under Gtk/EFL/Qt and perhaps others, BloomFilter is not fast allocated at all. This change simply instructs the system to build BloomFilter as a fast-allocated object, removing the error case under Windows and potentially speeding up memory allocation on other platforms.

Attachments
Patch (1.03 KB, patch) 2013-05-02 11:33 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (1.09 KB, patch) 2013-05-03 09:49 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.