REGRESSION (from 419.3) Google Reader List & Expanded view are broken

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Benjamin Mironer]

Google reader list view & expanded view (go to "All Items" to see them) do not display properly.
Regular Safari from Tiger (419.3) works fine.

[Bill Burcham]

In expanded view, the hyperlink/controls at the bottom of each item are jumbled and missing their icons.  Looks like an image replacement problem since the hyperlinks are present and functional.

Some controls at the bottom of each item are not functional at all: "edit tags", and "email".

[Michael Sorensen]

Created attachment 11521 [details]
Google Reader Rendering

This is a screen grab of the Google Reader rendering in the latest webkit (2.0.4/419.3).

[Stephanie Lewis]

In Radar 
<rdar://problem/4946991>

[W. Andy Carrel]

Spent a little time chasing this down today. It turns out this is caused by the fact that the current JavaScriptCore interaction with the document doesn't do the right thing with node.className="foo". This should result in the equivalent to <node class="foo"> but instead it results in <node classname="foo">.

[W. Andy Carrel]

(In reply to comment #4)
> Spent a little time chasing this down today. It turns out this is caused by the
> fact that the current JavaScriptCore interaction with the document doesn't do
> the right thing with node.className="foo". This should result in the equivalent
> to <node class="foo"> but instead it results in <node classname="foo">.

False start, 10 yard penalty on me. JavaScript that works for this on Firefox is:
somediv.setAttribute("class", "foo");
somediv.className = "foo";

I'll have to look a little harder.

[Maciej Stachowiak]

I think this might be a bug in Google's user agent detection. If so, we will need them to fix it.

(In reply to comment #6)
> I think this might be a bug in Google's user agent detection. If so, we will
> need them to fix it.
> 

See bug 12597 comment #4.

[Beth Dakin]

I just confirmed, that like http://bugs.webkit.org/show_bug.cgi?id=12597 , this bug was caused by:
http://trac.webkit.org/projects/webkit/changeset/13555

And it is, indeed, a bug in Google's user agent detection. contains should only be defined for elements, but we wrongly defined it for the document in Safari 2.0. The above change fixed our behavior so that we only support contains for elements. Unfortunately, many Google sites seem to detect Safari by looking for document.contains. And now that we don't support it any more, they don't know it's us!

I am going to mark this as a duplicate since it is the same problem.

*** This bug has been marked as a duplicate of 12597 ***