RESOLVED FIXED 12597
Google reader's article bubble has a pixel break
https://bugs.webkit.org/show_bug.cgi?id=12597
Summary Google reader's article bubble has a pixel break
Maciej Stachowiak
Reported 2007-02-04 11:04:55 PST
2007-01-29 12:54:44 Alice Liu: Reason for clone: applicable to Leopard Safari <original text: begin> 1/26/07 11:25 AM Lou Amadio: Each RSS article presented in google reader has a multipart image wrapping it - looks like a rounded rect. There is a break at the bottom most part of the image. see attached </original text: end> 2007-01-29 12:54:44 Cloned from problemID rdar://problem/4957442 by: Alice Liu. 2007-01-29 12:54:44 Alice Liu: <original text: begin> 2007-01-26 15:43:21 Lou Amadio: scrubbed for content - alice liu </original text: end> Reason for clone: applicable to Leopard Safari 2007-01-29 12:55:29 Alice Liu: I meant "applicable to Safari TOT". <rdar://problem/4961713>
Attachments
mitz
Comment 1 2007-02-04 11:12:23 PST
View -> Make Text Smaller eliminates the crack. Bigger text sizes make it bigger.
Beth Dakin
Comment 2 2007-02-10 19:02:21 PST
I'm not sure the pixel break is actually the problem here. There is definitely a pixel break, but we are failing to load the little icons that go along with the links and we are failing to space them out correctly too. I think that whatever that bug is is causing the table cell to be a bit bigger or perhaps just positioned differently, and therefore causing a pixel break. Anyway, I just tracked down the regression to a range using the nightlies, and the two symptoms (the lack of icons and correct spacing and the pixel break) all appeared at the same time: between r13536 and r13555. None of the check-ins in the range are super obvious.
Beth Dakin
Comment 3 2007-02-12 13:01:04 PST
I just confirmed that this regression was caused by: http://trac.webkit.org/projects/webkit/changeset/13555 CC-ing Maciej since that was his patch.
Mark Malone
Comment 4 2007-02-16 15:47:24 PST
Hyatt says: There's a user agent check for .contains on document. We fixed .contains to properly be defined only on Element.
David Kilzer (:ddkilzer)
Comment 5 2007-02-17 08:21:39 PST
Since this is now an evangelism bug, changing priority from P1->P2.
David Kilzer (:ddkilzer)
Comment 6 2007-02-21 09:40:21 PST
(In reply to comment #5) > Since this is now an evangelism bug, changing priority from P1->P2. See also Bug 11551 Comment #6.
Beth Dakin
Comment 7 2007-02-27 16:20:18 PST
*** Bug 11551 has been marked as a duplicate of this bug. ***
Beth Dakin
Comment 8 2007-02-27 16:22:58 PST
As Dave mentions above, http://bugs.webkit.org/show_bug.cgi?id=11551 (which is now a duplicate of this bug), shows that Google reader's list and expanded views suffer from the same detection problem.
Shawn Smith
Comment 9 2007-03-17 03:36:55 PDT
This is fixed as of Sunday March 17, 2007 with the latest nightly builds.
Beth Dakin
Comment 10 2007-03-18 13:41:45 PDT
Sweet! Marking as fixed.
Note You need to log in before you can comment on or make changes to this bug.