Bug 115432

Summary:

REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

Tables

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, jchaffraix, robert

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Reduction	none
Patch	jchaffraix: review+

Description Robert Hogan 2013-04-30 11:08:20 PDT

This is the webkit counterpart to https://code.google.com/p/chromium/issues/detail?id=227017

Comment 1 Robert Hogan 2013-04-30 11:09:28 PDT

Created attachment 200133 [details]
Reduction

Comment 2 Robert Hogan 2013-04-30 12:54:10 PDT

Created attachment 200142 [details]
Patch

Comment 3 Julien Chaffraix 2013-05-02 11:20:04 PDT

Comment on attachment 200142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200142&action=review

> Source/WebCore/rendering/RenderTableCell.cpp:408
> +    if (oldStyle && style()->verticalAlign() != oldStyle->verticalAlign())

Let's add a comment about why this is required.

Comment 4 Robert Hogan 2013-05-04 00:45:20 PDT

Committed r149553: <http://trac.webkit.org/changeset/149553>