Bug 115432

Summary: REGRESSION(r140907): Incorrect baseline on cells after updating vertical-align
Product: WebKit Reporter: Robert Hogan <robert>
Component: TablesAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, jchaffraix, robert
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Reduction
none
Patch jchaffraix: review+

Robert Hogan
Reported 2013-04-30 11:08:20 PDT
This is the webkit counterpart to https://code.google.com/p/chromium/issues/detail?id=227017
Attachments
Reduction (1.12 KB, text/html)
2013-04-30 11:09 PDT, Robert Hogan 		no flags
Details
Patch (4.77 KB, patch)
2013-04-30 12:54 PDT, Robert Hogan 		jchaffraix: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2013-04-30 11:09:28 PDT
Created attachment 200133 [details] Reduction
Robert Hogan
Comment 2 2013-04-30 12:54:10 PDT
Created attachment 200142 [details] Patch
Julien Chaffraix
Comment 3 2013-05-02 11:20:04 PDT
Comment on attachment 200142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200142&action=review > Source/WebCore/rendering/RenderTableCell.cpp:408 > + if (oldStyle && style()->verticalAlign() != oldStyle->verticalAlign()) Let's add a comment about why this is required.
Robert Hogan
Comment 4 2013-05-04 00:45:20 PDT
Committed r149553: <http://trac.webkit.org/changeset/149553>
Note You need to log in before you can comment on or make changes to this bug.