Summary: | Make RunLoop ref-counted | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eflews.bot, gyuyoung.kim, gyuyoung.kim, rakuco, rego+ews, rniwa, webkit-ews, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 115407, 115409 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Anders Carlsson
2013-04-29 16:34:24 PDT
Created attachment 200056 [details]
Patch
Created attachment 200057 [details]
Patch
Comment on attachment 200057 [details] Patch Attachment 200057 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/220992 Comment on attachment 200057 [details] Patch Attachment 200057 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/194901 Comment on attachment 200057 [details] Patch Attachment 200057 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/238635 Comment on attachment 200057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200057&action=review > Source/WebCore/platform/cf/RunLoopCF.cpp:41 > + s_mainRunLoop = adoptPtr(new RunLoop(CFRunLoopGetMain())).leakPtr(); EWS bot says you need to include PassOwnPtr.h in this source file. (In reply to comment #6) > (From update of attachment 200057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200057&action=review > > > Source/WebCore/platform/cf/RunLoopCF.cpp:41 > > + s_mainRunLoop = adoptPtr(new RunLoop(CFRunLoopGetMain())).leakPtr(); > > EWS bot says you need to include PassOwnPtr.h in this source file. And that’s revealing a bug! This should be using adoptRef. Created attachment 200060 [details]
Patch
Comment on attachment 200060 [details] Patch Attachment 200060 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/218663 Created attachment 200061 [details]
Patch
Committed r149338: <http://trac.webkit.org/changeset/149338> Re-opened since this is blocked by bug 115409 Created attachment 200191 [details]
Patch
Committed r149415: <http://trac.webkit.org/changeset/149415> |