Bug 115384 - Make RunLoop ref-counted
Summary: Make RunLoop ref-counted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 115407 115409
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-29 16:34 PDT by Anders Carlsson
Modified: 2013-04-30 17:01 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2013-04-29 16:35 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (3.74 KB, patch)
2013-04-29 16:36 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (3.74 KB, patch)
2013-04-29 17:01 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (4.96 KB, patch)
2013-04-29 17:07 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (3.09 KB, patch)
2013-04-30 16:46 PDT, Anders Carlsson 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-29 16:34:24 PDT 
Make RunLoop ref-counted
Comment 1 Anders Carlsson 2013-04-29 16:35:48 PDT 
Created attachment 200056 [details]
Patch
Comment 2 Anders Carlsson 2013-04-29 16:36:18 PDT 
Created attachment 200057 [details]
Patch
Comment 3 Early Warning System Bot 2013-04-29 16:40:24 PDT 
Comment on attachment 200057 [details]
Patch

Attachment 200057 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/220992
Comment 4 Build Bot 2013-04-29 16:41:10 PDT 
Comment on attachment 200057 [details]
Patch

Attachment 200057 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/194901
Comment 5 EFL EWS Bot 2013-04-29 16:43:21 PDT 
Comment on attachment 200057 [details]
Patch

Attachment 200057 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/238635
Comment 6 Darin Adler 2013-04-29 16:47:36 PDT 
Comment on attachment 200057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200057&action=review

> Source/WebCore/platform/cf/RunLoopCF.cpp:41
> +        s_mainRunLoop = adoptPtr(new RunLoop(CFRunLoopGetMain())).leakPtr();

EWS bot says you need to include PassOwnPtr.h in this source file.
Comment 7 Anders Carlsson 2013-04-29 16:50:19 PDT 
(In reply to comment #6)
> (From update of attachment 200057 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200057&action=review
> 
> > Source/WebCore/platform/cf/RunLoopCF.cpp:41
> > +        s_mainRunLoop = adoptPtr(new RunLoop(CFRunLoopGetMain())).leakPtr();
> 
> EWS bot says you need to include PassOwnPtr.h in this source file.

And that’s revealing a bug! This should be using adoptRef.
Comment 8 Anders Carlsson 2013-04-29 17:01:22 PDT 
Created attachment 200060 [details]
Patch
Comment 9 EFL EWS Bot 2013-04-29 17:07:07 PDT 
Comment on attachment 200060 [details]
Patch

Attachment 200060 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/218663
Comment 10 Anders Carlsson 2013-04-29 17:07:27 PDT 
Created attachment 200061 [details]
Patch
Comment 11 Anders Carlsson 2013-04-29 17:23:03 PDT 
Committed r149338: <http://trac.webkit.org/changeset/149338>
Comment 12 WebKit Commit Bot 2013-04-30 03:40:25 PDT 
Re-opened since this is blocked by bug 115409
Comment 13 Anders Carlsson 2013-04-30 16:46:35 PDT 
Created attachment 200191 [details]
Patch
Comment 14 Anders Carlsson 2013-04-30 17:01:19 PDT 
Committed r149415: <http://trac.webkit.org/changeset/149415>