RESOLVED FIXED115384
Make RunLoop ref-counted 
https://bugs.webkit.org/show_bug.cgi?id=115384
Summary Make RunLoop ref-counted
Anders Carlsson
Reported 2013-04-29 16:34:24 PDT
Make RunLoop ref-counted
Attachments
Patch (3.74 KB, patch)
2013-04-29 16:35 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.74 KB, patch)
2013-04-29 16:36 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.74 KB, patch)
2013-04-29 17:01 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2013-04-29 17:07 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2013-04-30 16:46 PDT, Anders Carlsson 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-04-29 16:35:48 PDT
Created attachment 200056 [details] Patch
Anders Carlsson
Comment 2 2013-04-29 16:36:18 PDT
Created attachment 200057 [details] Patch
Early Warning System Bot
Comment 3 2013-04-29 16:40:24 PDT
Comment on attachment 200057 [details] Patch Attachment 200057 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/220992
Build Bot
Comment 4 2013-04-29 16:41:10 PDT
Comment on attachment 200057 [details] Patch Attachment 200057 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/194901
EFL EWS Bot
Comment 5 2013-04-29 16:43:21 PDT
Comment on attachment 200057 [details] Patch Attachment 200057 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/238635
Darin Adler
Comment 6 2013-04-29 16:47:36 PDT
Comment on attachment 200057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200057&action=review > Source/WebCore/platform/cf/RunLoopCF.cpp:41 > + s_mainRunLoop = adoptPtr(new RunLoop(CFRunLoopGetMain())).leakPtr(); EWS bot says you need to include PassOwnPtr.h in this source file.
Anders Carlsson
Comment 7 2013-04-29 16:50:19 PDT
(In reply to comment #6) > (From update of attachment 200057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200057&action=review > > > Source/WebCore/platform/cf/RunLoopCF.cpp:41 > > + s_mainRunLoop = adoptPtr(new RunLoop(CFRunLoopGetMain())).leakPtr(); > > EWS bot says you need to include PassOwnPtr.h in this source file. And that’s revealing a bug! This should be using adoptRef.
Anders Carlsson
Comment 8 2013-04-29 17:01:22 PDT
Created attachment 200060 [details] Patch
EFL EWS Bot
Comment 9 2013-04-29 17:07:07 PDT
Comment on attachment 200060 [details] Patch Attachment 200060 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/218663
Anders Carlsson
Comment 10 2013-04-29 17:07:27 PDT
Created attachment 200061 [details] Patch
Anders Carlsson
Comment 11 2013-04-29 17:23:03 PDT
Committed r149338: <http://trac.webkit.org/changeset/149338>
WebKit Commit Bot
Comment 12 2013-04-30 03:40:25 PDT
Re-opened since this is blocked by bug 115409
Anders Carlsson
Comment 13 2013-04-30 16:46:35 PDT
Created attachment 200191 [details] Patch
Anders Carlsson
Comment 14 2013-04-30 17:01:19 PDT
Committed r149415: <http://trac.webkit.org/changeset/149415>
Note You need to log in before you can comment on or make changes to this bug.