| Summary: | [WK2] Remove build warnings by -Wunused-parameter | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||||
| Component: | WebKit Misc. | Assignee: | Jinwoo Song <jinwoo7.song> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, luiz, noam, zeno | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jinwoo Song
2013-04-28 23:22:00 PDT
Created attachment 199986 [details]
Patch
Comment on attachment 199986 [details]
Patch
LGTM, needs WK2 owner.
Comment on attachment 199986 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199986&action=review > Source/WebKit2/UIProcess/DrawingAreaProxy.h:71 > + virtual void waitForPossibleGeometryUpdate(double timeout = didUpdateBackingStoreStateTimeout) { UNUSED_PARAM(timeout); } This can just be virtual void waitForPossibleGeometryUpdate(double = didUpdateBackingStoreStateTimeout) { } Created attachment 199997 [details]
patch for landing.
Applied Anders's comment.
Comment on attachment 199997 [details] patch for landing. Rejecting attachment 199997 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 199997, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/195674 Comment on attachment 199997 [details] patch for landing. Clearing flags on attachment: 199997 Committed r149279: <http://trac.webkit.org/changeset/149279> All reviewed patches have been landed. Closing bug. |