Bug 115333 – requestAnimationFrame() reports future timestamp.

• Component: WebCore Misc.
• Status: RESOLVED DUPLICATE

[zalan]

'callback FrameRequestCallback = void (DOMHighResTimeStamp time);'  reports future 'time'

according to the spec (http://www.w3.org/TR/animation-timing/#FrameRequestCallback)

"
Let time be t expressed as the number of milliseconds since 1970-01-01T00:00:00Z. 
...
Perform the steps defined in the invoke callbacks algorithm with parameters list and time
"
(For DOMHighResTimeStamp, the time value measured relative to the navigationStart instead)

[zalan]

patch is coming.

[zalan]

Created attachment 200039 [details]
Patch

[zalan]

it needs https://bugs.webkit.org/show_bug.cgi?id=111244 to be landed first (to get the layouttest work)

[David Kilzer (:ddkilzer)]

<rdar://problem/13758535>

[David Kilzer (:ddkilzer)]

(In reply to comment #0)
> 'callback FrameRequestCallback = void (DOMHighResTimeStamp time);'  reports future 'time'

It's in the future because the timestamp is based on the wrong epoch, correct?

[David Kilzer (:ddkilzer)]

Comment on attachment 200039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200039&action=review

> Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp:95
> +    MutexLocker lock(m_mutex);

The Blackberry version of this method uses a tryLock instead, so I don't think it can be replaced with a version that blocks.

[Build Bot]

Comment on attachment 200039 [details]
Patch

Attachment 200039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/245176

New failing tests:
fast/animation/request-animation-frame-future-timestamp-value.html

[Build Bot]

Created attachment 200052 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 200039 [details]
Patch

Attachment 200039 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/249012

New failing tests:
fast/animation/request-animation-frame-future-timestamp-value.html

[Build Bot]

Created attachment 200067 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[zalan]

(In reply to comment #10)
> Created an attachment (id=200067) [details]
> Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
> 
> The attached test failures were seen while running run-webkit-tests on the mac-ews.
> Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
layouttest failures are because of the missing performance.now() API. (https://bugs.webkit.org/show_bug.cgi?id=111244)

[zalan]

(In reply to comment #6)
> (From update of attachment 200039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200039&action=review
> 
> > Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp:95
> > +    MutexLocker lock(m_mutex);
> 
> The Blackberry version of this method uses a tryLock instead, so I don't think it can be replaced with a version that blocks.

I was going to ask the RIM guys to check if it still holds true (whether they've or planning to switch to WK2 as this tryLock() call is irrelevant in WK2 context) also, I am not so sure if skipping frames is a good idea. Anyway, I'll revert those changes and deal with them separately.

[zalan]

(In reply to comment #5)
> (In reply to comment #0)
> > 'callback FrameRequestCallback = void (DOMHighResTimeStamp time);'  reports future 'time'
> 
> It's in the future because the timestamp is based on the wrong epoch, correct?

It is in the future because the timestamp is adjusted with 'timeUntilOutput'.

[zalan]

Created attachment 200113 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 200113 [details]
Patch

So we need to capture monotonicallyIncreasingTime() in a way where all the RAF callbacks use the same timestamp, and the same time is used to drive CSS animations. I'm not sure this does that.

[Said Abou-Hallawa]

*** This bug has been marked as a duplicate of bug 159038 ***