Bug 115325

Summary: Remove Chromium code from Tools/BuildSlaveSupport
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+, benjamin: commit-queue-

Zan Dobersek
Reported 2013-04-28 04:49:25 PDT
Remove Chromium code from Tools/BuildSlaveSupport
Attachments
Patch (12.47 KB, patch)
2013-04-28 05:00 PDT, Zan Dobersek 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-04-28 05:00:54 PDT
Created attachment 199963 [details] Patch
Benjamin Poulain
Comment 2 2013-04-28 15:33:37 PDT
Comment on attachment 199963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199963&action=review Gosh, we keep cleaning and you keep finding crap everywhere :( > Tools/BuildSlaveSupport/built-product-archive:95 > - > - # Chromium bots may not have this directory > if not os.path.isdir(archiveDir): > os.mkdir(archiveDir) Shouldn't the if go away? If the comment is correct, it has become useless.
Ryosuke Niwa
Comment 3 2013-04-28 15:46:35 PDT
Comment on attachment 199963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199963&action=review >> Tools/BuildSlaveSupport/built-product-archive:95 >> os.mkdir(archiveDir) > > Shouldn't the if go away? > If the comment is correct, it has become useless. Yup, we should get rid of it. > Tools/BuildSlaveSupport/test-result-archive:-101 > - zipper = zipfile.ZipFile(archiveFile, 'w', zipfile.ZIP_DEFLATED) You can also remove zipfile from the import list.
Zan Dobersek
Comment 4 2013-04-28 23:50:18 PDT
Committed r149270: <http://trac.webkit.org/changeset/149270>
Zan Dobersek
Comment 5 2013-04-28 23:51:20 PDT
(In reply to comment #4) > Committed r149270: <http://trac.webkit.org/changeset/149270> ... with all the comments addressed, thanks for the reviews.
Note You need to log in before you can comment on or make changes to this bug.