| Summary: | [WK2] Threads get stuck in NetworkProcess when canceling loads in WebProcess | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, beidson, commit-queue | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Proskuryakov
2013-04-27 19:40:53 PDT
Created attachment 199926 [details]
proposed fix
Comment on attachment 199926 [details] proposed fix Clearing flags on attachment: 199926 Committed r149251: <http://trac.webkit.org/changeset/149251> All reviewed patches have been landed. Closing bug. This re-introduced the crashed fixed in https://bugs.webkit.org/show_bug.cgi?id=115061 Also: "...alrady canceled..." ? :) Sadly, this means that the bug is much harder to fix - the null check being necessary means that we can't send messages back. Re-added the null check in <http://trac.webkit.org/r149298>. Created attachment 200126 [details]
Patch v2
This patch was originally written by Alexey, reviewed by me, then tweaked and tested heavily by me... so I'll give him a chance to review back!
Comment on attachment 200126 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=200126&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:112 > + // If m_coreLoader becomse null as a result of the didReceiveResponse callback, we can't use the send function(). Typo: becomse |