Summary: | Get rid of StorageTask | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, gyuyoung.kim, philn, rakuco, rego+ews, rniwa, webkit-ews, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Anders Carlsson
2013-04-27 14:06:16 PDT
Created attachment 199916 [details]
Patch
Attachment 199916 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1
Source/WebCore/storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.cpp:84: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.h:65: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/221054 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/187339 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/169284 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/12265 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47710 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/131432 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/221060 Comment on attachment 199916 [details] Patch Attachment 199916 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/238118 Created attachment 200023 [details]
Patch
Attachment 200023 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1
Source/WebCore/storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.cpp:84: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.h:65: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 200023 [details] Patch Attachment 200023 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/229545 Comment on attachment 200023 [details] Patch Attachment 200023 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/195734 Created attachment 200024 [details]
Patch
Attachment 200024 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/storage/StorageSyncManager.cpp', u'Source/WebCore/storage/StorageTask.cpp', u'Source/WebCore/storage/StorageTask.h', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebCore/storage/StorageThread.h', u'Source/WebCore/storage/StorageTracker.cpp']" exit_code: 1
Source/WebCore/storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.cpp:84: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/storage/StorageThread.h:65: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 200024 [details]
Patch
r=me
Committed r149297: <http://trac.webkit.org/changeset/149297> |