| Summary: | [BlackBerry] Update HTML5 progress bar UX | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tiancheng Jiang <tijiang> | ||||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, jrogers, rniwa | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tiancheng Jiang
2013-04-26 15:44:23 PDT
Created attachment 199868 [details]
Patch
Comment on attachment 199868 [details] Patch Attachment 199868 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/42711 New failing tests: fast/frames/crash-remove-iframe-during-object-beforeload.html Created attachment 199881 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.2
You will need to update this patch as it looks like you reintroduced the old logic for painting the slider track and a whole bunch of obsolete constants. This patch should only be adding the new progress bar logic. This is just a revert patch and I have the real patch coming. But I am not sure how could this patch break the DRT test. (In reply to comment #4) > You will need to update this patch as it looks like you reintroduced the old logic for painting the slider track and a whole bunch of obsolete constants. This patch should only be adding the new progress bar logic. Comment on attachment 199868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199868&action=review Please remove the Skia block. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:751 > +#if USE(SKIA) I don't think you want to add SKIA specific code anymore. Comment on attachment 199868 [details]
Patch
It turns out the SKIA block is temporary, so this can go in.
Comment on attachment 199868 [details] Patch Clearing flags on attachment: 199868 Committed r149614: <http://trac.webkit.org/changeset/149614> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 200728 [details]
Patch
Comment on attachment 200728 [details]
Patch
Ok.
Comment on attachment 200728 [details] Patch Clearing flags on attachment: 200728 Committed r149624: <http://trac.webkit.org/changeset/149624> All reviewed patches have been landed. Closing bug. |