Bug 115270

Summary: [WKTR] Tests dumping audio data shouldn't dump pixels
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, buildbot, commit-queue, eric.carlson, jer.noble, pnormand, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

Description Zan Dobersek 2013-04-26 11:29:50 PDT 
[WKTR] Tests dumping audio data shouldn't dump pixels
Comment 1 Zan Dobersek 2013-04-26 11:33:03 PDT 
Created attachment 199850 [details]
Patch
Comment 2 Build Bot 2013-04-26 13:17:31 PDT 
Comment on attachment 199850 [details]
Patch

Attachment 199850 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/214121

New failing tests:
fast/frames/crash-remove-iframe-during-object-beforeload.html
Comment 3 Build Bot 2013-04-26 13:17:33 PDT 
Created attachment 199854 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Benjamin Poulain 2013-04-27 18:31:31 PDT 
Comment on attachment 199850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199850&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:383
>      WKRetainPtr<WKDataRef> audioData(AdoptWK, WKBundleCreateWKDataFromUInt8Array(InjectedBundle::shared().bundle(), context, data));
>      InjectedBundle::shared().setAudioResult(audioData.get());
>      m_whatToDump = Audio;
> +    m_dumpPixels = false;

Maybe rename setAudioData to setAudioResult?
Comment 5 Zan Dobersek 2013-04-28 05:34:28 PDT 
Comment on attachment 199850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199850&action=review

>> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:383
>> +    m_dumpPixels = false;
> 
> Maybe rename setAudioData to setAudioResult?

Sounds better. I'll do that in a separate patch.
Comment 6 Zan Dobersek 2013-04-28 05:38:16 PDT 
Comment on attachment 199850 [details]
Patch

Clearing flags on attachment: 199850

Committed r149258: <http://trac.webkit.org/changeset/149258>
Comment 7 Zan Dobersek 2013-04-28 05:38:22 PDT 
All reviewed patches have been landed.  Closing bug.