Bug 115266

Summary:

RenderMeter::valueRatio() is private

Product:

WebKit

Reporter:

Daker Fernandes Pinheiro <daker.pinheiro>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

benjamin, commit-queue, esprehn+autocc, jesus, menard, morrita

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

115343

Bug Blocks:

Attachments:

Description	Flags
Change method visibility	none
Change method visibility with fixed ChangeLog	none
Remove unused method RenderMeter::valueRatio()	none

Daker Fernandes Pinheiro

Reported 2013-04-26 10:55:20 PDT

This function is currently unused. However, it is necessary to implement a RenderTheme capable of rendering Meter elements.

Attachments
Change method visibility (1.42 KB, patch) 2013-04-26 11:07 PDT, Daker Fernandes Pinheiro	no flags	Details Formatted Diff Diff
Change method visibility with fixed ChangeLog (1.60 KB, patch) 2013-04-26 11:15 PDT, Daker Fernandes Pinheiro	no flags	Details Formatted Diff Diff
Remove unused method RenderMeter::valueRatio() (1.79 KB, patch) 2013-04-29 10:41 PDT, Daker Fernandes Pinheiro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daker Fernandes Pinheiro

Comment 1 2013-04-26 11:07:31 PDT

Created attachment 199845 [details] Change method visibility

Jesus Sanchez-Palencia

Comment 2 2013-04-26 11:11:42 PDT

Comment on attachment 199845 [details] Change method visibility View in context: https://bugs.webkit.org/attachment.cgi?id=199845&action=review > Source/WebCore/ChangeLog:8 > + No new tests. You should specify the reason why no new tests were needed (e.g.: "No new tests, no behavior was changed"). > Source/WebCore/rendering/RenderMeter.h:41 > + double valueRatio() const; Why do you need it to public? A 1-line explanation in Changelog should be enough. :)

Daker Fernandes Pinheiro

Comment 3 2013-04-26 11:15:55 PDT

Created attachment 199846 [details] Change method visibility with fixed ChangeLog

WebKit Commit Bot

Comment 4 2013-04-26 12:08:55 PDT

Comment on attachment 199846 [details] Change method visibility with fixed ChangeLog Clearing flags on attachment: 199846 Committed r149203: <http://trac.webkit.org/changeset/149203>

WebKit Commit Bot

Comment 5 2013-04-26 12:08:58 PDT

All reviewed patches have been landed. Closing bug.

Benjamin Poulain

Comment 6 2013-04-28 21:59:52 PDT

What? Please explain this change. I could understand for <progress> but for <meter> the rendering depends on the gaugeRegion and you cannot access that from the renderer. You must access the MeterElement to style the element correctly, and have all styling parameters available there.

WebKit Commit Bot

Comment 7 2013-04-28 22:07:48 PDT

Re-opened since this is blocked by bug 115343

Daker Fernandes Pinheiro

Comment 8 2013-04-29 07:26:04 PDT

I also though strange that it is a private method and no one was using it. It looked to me like a forgotten piece of code. I was using the valueRatio because is a simplest way to paint a minimal meter element, since it already does the ratio math. Since it looked like RenderProgress position parameter, I made it public to use it in my own style. Since it is not used anywhere, shouldn't it be deleted?

Daker Fernandes Pinheiro

Comment 9 2013-04-29 10:41:00 PDT

Created attachment 200025 [details] Remove unused method RenderMeter::valueRatio()

WebKit Commit Bot

Comment 10 2013-04-29 13:15:13 PDT

Comment on attachment 200025 [details] Remove unused method RenderMeter::valueRatio() Clearing flags on attachment: 200025 Committed r149308: <http://trac.webkit.org/changeset/149308>

WebKit Commit Bot

Comment 11 2013-04-29 13:15:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.