Bug 115260

Summary: Web Inspector: support frame instrumentation for coordinated graphics
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Web Inspector (Deprecated)Assignee: Roland Takacs <rtakacs>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cmarcelo, commit-queue, graouts, hnandor, joepeck, kadam, kling, luiz, ossy, rtakacs, sergio, timothy, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 88225    
Attachments:
Description Flags
patch
kling: review+, kling: commit-queue-
patch none

Noam Rosenthal
Reported 2013-04-26 07:57:39 PDT
Currently frame instrumentation only works for Blackberry (and for Chromium in Blink) We need to support it in coordinated graphics for Qt/EFL, by calling the right functions from CoordinatedLayerTreeHost and enabling the flag.
Attachments
patch (3.39 KB, patch)
2013-05-21 04:56 PDT, Roland Takacs 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
patch (3.39 KB, patch)
2013-05-23 02:03 PDT, Roland Takacs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roland Takacs
Comment 1 2013-05-21 04:56:47 PDT
Created attachment 202413 [details] patch Overrode supportsFrameInstrumentation in order to enable frame instrumentation on ports that use coordinated graphics. didBeginFrame() needs to be called to render bars.
Noam Rosenthal
Comment 2 2013-05-21 05:00:04 PDT
Comment on attachment 202413 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=202413&action=review LGTM, but needs owner review as it touches common WebKit2 files. > Source/WebKit2/ChangeLog:9 > + when didBeginFrame() is called. you mean "by calling didBeginFrame()"
Andreas Kling
Comment 3 2013-05-22 11:23:57 PDT
Comment on attachment 202413 [details] patch o=me
Roland Takacs
Comment 4 2013-05-23 02:03:49 PDT
Created attachment 202650 [details] patch
Ádám Kallai
Comment 5 2013-05-23 02:37:35 PDT
Landed: http://trac.webkit.org/changeset/150578
Note You need to log in before you can comment on or make changes to this bug.