Bug 11526

Summary: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: mitz
Priority: P1 Keywords: LayoutTestFailure, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://build.webkit.org/results/post-commit-powerpc-mac-os-x/4288/svg/custom/create-metadata-element-diffs.txt
Attachments:
Description Flags
Bring consistency to DOMNode::toString/valueOf mjs: review+

Description Mark Rowe (bdash) 2006-11-06 03:27:37 PST 
The fix for bug 11524 broke this test as it caused DOMNode::valueOf() to be used when comparing [meta] to a string, rather than DOMNode::toString().  In Firefox DOMNode::valueOf() and DOMNode::toString() return the same value, but we return a string based on nodeName for the former, and className for the latter.
Comment 1 Mark Rowe (bdash) 2006-11-06 04:56:13 PST 
Created attachment 11396 [details]
Bring consistency to DOMNode::toString/valueOf
Comment 2 Maciej Stachowiak 2006-11-06 04:57:45 PST 
Comment on attachment 11396 [details]
Bring consistency to DOMNode::toString/valueOf

r=me
Comment 3 mitz 2006-11-06 05:03:23 PST 
+FAILURE: expected "[object META]", actual "[object HTMLMetaElement]"

Perhaps the test can adjust its expectations.
Comment 4 Mark Rowe (bdash) 2006-11-06 05:13:01 PST 
Landed in r17615, fast/dom/HTMLMetaElement/meta-attributes.html results updated in r17616.  Good catch :)