Bug 115257 – Remove duplicated null check in DocumentWriter::end()

• Component: WebCore Misc.
• Status: RESOLVED INVALID

[Kangil Han]

DocumentWriter::end() has duplicated null check, so delete it.

[Kangil Han]

Created attachment 199828 [details]
Patch

[Build Bot]

Comment on attachment 199828 [details]
Patch

Attachment 199828 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/38698

New failing tests:
fast/frames/set-parent-src-synchronously.xhtml
fast/parser/iframe-sets-parent-to-javascript-url.html

[Build Bot]

Created attachment 199833 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Andreas Kling]

Comment on attachment 199828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199828&action=review

> Source/WebCore/loader/DocumentWriter.cpp:-247
>      m_parser->flush(this);
> -    if (!m_parser)
> -        return;

Are you sure m_parser can't get nulled out below flush()?

[Darin Adler]

Comment on attachment 199828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199828&action=review

>> Source/WebCore/loader/DocumentWriter.cpp:-247
>> -        return;
> 
> Are you sure m_parser can't get nulled out below flush()?

It seems to me that it could. I don’t think this change is correct.