Bug 115247

Summary: Optimize function and interface object length computation in bindings generator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, haraken, laszlo.gombos, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115250    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-04-26 05:21:11 PDT
We should introduce a new GetFunctionLength() function that efficiently computes the length of a function (i.e. its number of mandatory parameters). We currently call GenerateFunctionParametersCheck() for that purpose but this is very inefficient because it does a lot more processing than we need in this case, in order to generate the expression to check the parameters.
Attachments
Patch (5.50 KB, patch)
2013-04-26 05:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-04-26 05:31:22 PDT
Created attachment 199816 [details] Patch
Kentaro Hara
Comment 2 2013-04-26 05:34:54 PDT
Comment on attachment 199816 [details] Patch Thanks for cleaning up the mess we introduced!
WebKit Commit Bot
Comment 3 2013-04-26 06:02:18 PDT
Comment on attachment 199816 [details] Patch Clearing flags on attachment: 199816 Committed r149177: <http://trac.webkit.org/changeset/149177>
WebKit Commit Bot
Comment 4 2013-04-26 06:02:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.