Bug 115240

Summary: [GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
Product: WebKit Reporter: Eduardo Lima Mitev <elima>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson, walters, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux none

Eduardo Lima Mitev
Reported 2013-04-26 03:37:14 PDT
Building WebKit Gtk port using build-webkit script fails in my system (up-to-date Debian Wheezy 64bits) with: ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: In member function 'void WebKit::ProcessLauncher::launchProcess()': ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:77:20: error: 'AF_UNIX' was not declared in this scope ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:77:29: error: 'SOCK_STREAM' was not declared in this scope ../../Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:77:52: error: 'socketpair' was not declared in this scope make[1]: *** [Source/WebKit2/UIProcess/Launcher/gtk/libwebkit2gtk_3_0_la-ProcessLauncherGtk.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/opt/jhbuild/gnome3/checkout/WebKit/WebKitBuild/Release' make: *** [all] Error 2 The error goes away by including "sys/socket.h".
Attachments
Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux (1.61 KB, patch)
2013-04-26 03:52 PDT, Eduardo Lima Mitev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eduardo Lima Mitev
Comment 1 2013-04-26 03:52:11 PDT
Created attachment 199810 [details] Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux
Eduardo Lima Mitev
Comment 2 2013-04-26 03:57:58 PDT
Adding xlopez and mrobinson to CC.
WebKit Commit Bot
Comment 3 2013-04-26 09:15:03 PDT
Comment on attachment 199810 [details] Includes "sys/socket.h" in ProcessLauncherGtk.cpp, if OS is Linux Clearing flags on attachment: 199810 Committed r149192: <http://trac.webkit.org/changeset/149192>
WebKit Commit Bot
Comment 4 2013-04-26 09:15:04 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 5 2013-04-27 09:46:20 PDT
*** Bug 115306 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.