Bug 115237

Summary: [GTK] Set up the TestWebCore in TestWebKitAPI
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115233, 115430, 115469, 115470    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2013-04-26 01:53:33 PDT
[GTK] Set up the TestWebCore in TestWebKitAPI
Attachments
Patch (5.13 KB, patch)
2013-04-26 02:01 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (5.22 KB, patch)
2013-05-01 12:12 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-04-26 02:01:27 PDT
Created attachment 199803 [details] Patch
Zan Dobersek
Comment 2 2013-04-26 02:02:41 PDT
Depends on the cleanup in bug #115233, meaning it won't apply in EWS. Can reupload when that bug is fixed.
Zan Dobersek
Comment 3 2013-04-29 13:16:17 PDT
Committed r149309: <http://trac.webkit.org/changeset/149309>
WebKit Commit Bot
Comment 4 2013-04-30 11:01:03 PDT
Re-opened since this is blocked by bug 115430
Zan Dobersek
Comment 5 2013-05-01 12:12:06 PDT
Created attachment 200232 [details] Patch
Gustavo Noronha (kov)
Comment 6 2013-05-03 13:12:24 PDT
Comment on attachment 200232 [details] Patch I couldn't spot the change that makes the new version better, I assume it's just that a different change made this change correct?
Zan Dobersek
Comment 7 2013-05-04 00:46:17 PDT
Yes, that's exactly the case. Sorry for leaving you confused there, I should have at least mentioned that the underlying issues were fixed in separate bugs or just recommit the patch.
Zan Dobersek
Comment 8 2013-05-04 00:49:24 PDT
Comment on attachment 200232 [details] Patch Clearing flags on attachment: 200232 Committed r149554: <http://trac.webkit.org/changeset/149554>
Zan Dobersek
Comment 9 2013-05-04 00:49:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.