Bug 115237

Summary: [GTK] Set up the TestWebCore in TestWebKitAPI
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115233, 115430, 115469, 115470    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Zan Dobersek 2013-04-26 01:53:33 PDT 
[GTK] Set up the TestWebCore in TestWebKitAPI
Comment 1 Zan Dobersek 2013-04-26 02:01:27 PDT 
Created attachment 199803 [details]
Patch
Comment 2 Zan Dobersek 2013-04-26 02:02:41 PDT 
Depends on the cleanup in bug #115233, meaning it won't apply in EWS. Can reupload when that bug is fixed.
Comment 3 Zan Dobersek 2013-04-29 13:16:17 PDT 
Committed r149309: <http://trac.webkit.org/changeset/149309>
Comment 4 WebKit Commit Bot 2013-04-30 11:01:03 PDT 
Re-opened since this is blocked by bug 115430
Comment 5 Zan Dobersek 2013-05-01 12:12:06 PDT 
Created attachment 200232 [details]
Patch
Comment 6 Gustavo Noronha (kov) 2013-05-03 13:12:24 PDT 
Comment on attachment 200232 [details]
Patch

I couldn't spot the change that makes the new version better, I assume it's just that a different change made this change correct?
Comment 7 Zan Dobersek 2013-05-04 00:46:17 PDT 
Yes, that's exactly the case.

Sorry for leaving you confused there, I should have at least mentioned that the underlying issues were fixed in separate bugs or just recommit the patch.
Comment 8 Zan Dobersek 2013-05-04 00:49:24 PDT 
Comment on attachment 200232 [details]
Patch

Clearing flags on attachment: 200232

Committed r149554: <http://trac.webkit.org/changeset/149554>
Comment 9 Zan Dobersek 2013-05-04 00:49:31 PDT 
All reviewed patches have been landed.  Closing bug.