Bug 115232

Summary: Pattern: add missing definitions for the BlackBerry port
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 114886    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch none

Alberto Garcia
Reported 2013-04-26 01:07:45 PDT
The following changes are needed: - Definition of PlatformPatternPtr - Declaration of Pattern::platformPattern(), defined in PatternBlackBerry.cpp - Don't compile the default implementations of platformDestroy() and setPlatformPatternSpaceTransform(), since they are already defined for BlackBerry. - Initialize m_pattern to 0.
Attachments
Patch (2.79 KB, patch)
2013-04-26 01:13 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-04-26 01:13:08 PDT
Created attachment 199796 [details] Patch
Alberto Garcia
Comment 2 2013-04-26 01:16:51 PDT
These changes would conflict with those written for bug 114886, so I made this patch to be applied on top of that one. Hence I'm setting a dependency on bug 114886. After that one is fixed we can apply this one.
Alberto Garcia
Comment 3 2013-05-02 07:15:32 PDT
Comment on attachment 199796 [details] Patch Removing this patch by now, I might need to change it.
Alberto Garcia
Comment 4 2014-01-09 23:46:57 PST
This bug is obsolete, closing.
Note You need to log in before you can comment on or make changes to this bug.