Bug 115223

Summary: [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
Product: WebKit Reporter: Andy Estes <aestes>
Component: WebKit2Assignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, beidson, darin, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch darin: review+

Andy Estes
Reported 2013-04-25 22:32:11 PDT
[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
Attachments
Patch (35.41 KB, patch)
2013-04-25 22:58 PDT, Andy Estes 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-04-25 22:33:14 PDT
<rdar://problem/12890540>
Andy Estes
Comment 2 2013-04-25 22:58:46 PDT
Created attachment 199785 [details] Patch
Andy Estes
Comment 3 2013-04-26 09:54:26 PDT
Committed r149194: <http://trac.webkit.org/changeset/149194>
Alexey Proskuryakov
Comment 4 2013-04-26 10:09:21 PDT
This change means that messages are now handled on a secondary thread. What is the design for CustomProtocolManager thread safety?
Andy Estes
Comment 5 2013-04-26 10:22:02 PDT
(In reply to comment #4) > This change means that messages are now handled on a secondary thread. What is the design for CustomProtocolManager thread safety? The messages that are handled on this thread do two things: 1) Look up a WKCustomProtocol by ID. This was made thread-safe in <http://trac.webkit.org/changeset/149121>. 2) Call a method on NSURLProtocolClient. I believe this is thread-safe by code inspection.
Andy Estes
Comment 6 2013-04-26 10:29:19 PDT
(In reply to comment #4) > This change means that messages are now handled on a secondary thread. What is the design for CustomProtocolManager thread safety? Oh, we do need to protect m_registeredSchemes. We add/remove schemes to that set from the work queue but look them up from some thread managed by NSURLConnection. I'll fix that in a follow-up. Thanks for making me double-check!
Andy Estes
Comment 7 2013-04-26 11:14:28 PDT
(In reply to comment #6) > I'll fix that in a follow-up. Filed <https://bugs.webkit.org/show_bug.cgi?id=115267>.
Note You need to log in before you can comment on or make changes to this bug.