Bug 115219

Summary:

StaticHashSetNodeList is unnecessary

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, benjamin, commit-queue, eflews.bot, esprehn+autocc, gtk-ews, gyuyoung.kim, gyuyoung.kim, kling, koivisto, rakuco, tonikitoo, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	none
Fixed EFL and Qt builds	none
Fixed Mac build	none
Fixed more builds	none
Fixed Windows build	none
Patch for landing	none
Another fixed Windows build	none
Another GTK+ fix	buildbot: commit-queue-

Ryosuke Niwa

Reported 2013-04-25 21:10:04 PDT

StaticHashSetNodeList is only used for Internals methods and as an intermediate data structure in TouchAdjustments.cpp. We should get rid of this class.

Attachments
Cleanup (32.34 KB, patch) 2013-04-25 21:13 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed EFL and Qt builds (32.80 KB, patch) 2013-04-25 21:23 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed Mac build (35.70 KB, patch) 2013-04-25 21:42 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed more builds (36.18 KB, patch) 2013-04-26 02:36 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed Windows build (36.63 KB, patch) 2013-04-26 03:10 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (39.23 KB, patch) 2013-04-27 12:37 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Another fixed Windows build (40.70 KB, patch) 2013-04-27 13:44 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Another GTK+ fix (41.60 KB, patch) 2013-04-27 14:14 PDT, Ryosuke Niwa	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-04-25 21:10:47 PDT

Inspired by https://chromium.googlesource.com/chromium/blink/+/78207c5c34383fbb807bb9347deb67168f09bb04.

Ryosuke Niwa

Comment 2 2013-04-25 21:13:42 PDT

Created attachment 199776 [details] Cleanup

EFL EWS Bot

Comment 3 2013-04-25 21:19:52 PDT

Comment on attachment 199776 [details] Cleanup Attachment 199776 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/223055

EFL EWS Bot

Comment 4 2013-04-25 21:20:56 PDT

Comment on attachment 199776 [details] Cleanup Attachment 199776 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/165357

Early Warning System Bot

Comment 5 2013-04-25 21:21:20 PDT

Comment on attachment 199776 [details] Cleanup Attachment 199776 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/200538

Ryosuke Niwa

Comment 6 2013-04-25 21:23:48 PDT

Created attachment 199777 [details] Fixed EFL and Qt builds

Ryosuke Niwa

Comment 7 2013-04-25 21:42:21 PDT

Created attachment 199779 [details] Fixed Mac build

Early Warning System Bot

Comment 8 2013-04-25 21:51:37 PDT

Comment on attachment 199779 [details] Fixed Mac build Attachment 199779 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/59993

Early Warning System Bot

Comment 9 2013-04-25 21:52:04 PDT

Comment on attachment 199779 [details] Fixed Mac build Attachment 199779 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/126286

Build Bot

Comment 10 2013-04-25 22:20:20 PDT

Comment on attachment 199779 [details] Fixed Mac build Attachment 199779 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/209054

kov's GTK+ EWS bot

Comment 11 2013-04-25 22:43:35 PDT

Comment on attachment 199779 [details] Fixed Mac build Attachment 199779 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/229013

Ryosuke Niwa

Comment 12 2013-04-26 02:36:46 PDT

Created attachment 199807 [details] Fixed more builds

Build Bot

Comment 13 2013-04-26 03:00:25 PDT

Comment on attachment 199807 [details] Fixed more builds Attachment 199807 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/77516

Ryosuke Niwa

Comment 14 2013-04-26 03:10:01 PDT

Created attachment 199809 [details] Fixed Windows build

Build Bot

Comment 15 2013-04-26 03:47:31 PDT

Comment on attachment 199809 [details] Fixed Windows build Attachment 199809 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/61539

kov's GTK+ EWS bot

Comment 16 2013-04-26 05:48:17 PDT

Comment on attachment 199809 [details] Fixed Windows build Attachment 199809 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/171432

Ryosuke Niwa

Comment 17 2013-04-27 12:37:30 PDT

Created attachment 199907 [details] Patch for landing

Build Bot

Comment 18 2013-04-27 13:06:09 PDT

Comment on attachment 199907 [details] Patch for landing Attachment 199907 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/229023

Ryosuke Niwa

Comment 19 2013-04-27 13:44:47 PDT

Created attachment 199913 [details] Another fixed Windows build

Ryosuke Niwa

Comment 20 2013-04-27 13:45:10 PDT

Comment on attachment 199913 [details] Another fixed Windows build Waiting for EWS to process it.

kov's GTK+ EWS bot

Comment 21 2013-04-27 14:07:58 PDT

Comment on attachment 199913 [details] Another fixed Windows build Attachment 199913 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/240094

Ryosuke Niwa

Comment 22 2013-04-27 14:14:49 PDT

Created attachment 199917 [details] Another GTK+ fix

Build Bot

Comment 23 2013-04-27 21:48:57 PDT

Comment on attachment 199917 [details] Another GTK+ fix Attachment 199917 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/25493

Ryosuke Niwa

Comment 24 2013-04-28 15:20:51 PDT

Committed r149262: <http://trac.webkit.org/changeset/149262>

Note You need to log in before you can comment on or make changes to this bug.