Bug 115193

Summary: Glyphs may fail to render when using SVG font
Product: WebKit Reporter: Antoine Quint <graouts>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, enrica, graouts, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2013-04-25 12:12:05 PDT
In certain circumstances, glyphs fail to render when using SVG fonts as the GlyphBuffer gets incorrect data when running through SimpleFontData::applyTransforms(). This method ought not be ran for SVG fonts.
Attachments
Patch (1.70 KB, patch)
2013-04-25 12:24 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2013-04-25 12:12:29 PDT
<rdar://problem/12893178>
Antoine Quint
Comment 2 2013-04-25 12:24:51 PDT
Created attachment 199736 [details] Patch
Simon Fraser (smfr)
Comment 3 2013-04-25 12:49:53 PDT
Comment on attachment 199736 [details] Patch There should be a way to make a layout test for this, no?
Antoine Quint
Comment 4 2013-04-25 12:51:31 PDT
(In reply to comment #3) > (From update of attachment 199736 [details]) > There should be a way to make a layout test for this, no? I couldn't manage to make a test case that'd reproduce the issue with a free SVG font.
Tim Horton
Comment 5 2013-04-25 12:54:00 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 199736 [details] [details]) > > There should be a way to make a layout test for this, no? > > I couldn't manage to make a test case that'd reproduce the issue with a free SVG font. Can't you just make one that causes trouble? They're not too hard to make (and we have some small examples in the SVG layout tests).
WebKit Commit Bot
Comment 6 2013-04-25 14:28:43 PDT
Comment on attachment 199736 [details] Patch Clearing flags on attachment: 199736 Committed r149144: <http://trac.webkit.org/changeset/149144>
WebKit Commit Bot
Comment 7 2013-04-25 14:28:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.