Bug 115178

Summary: [BlackBerry] Make scroll position adjustment work with pages with fixed position elements
Product: WebKit Reporter: Iris Wu <shuwu>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, commit-queue, rwlbuis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch with ChangeLog
none
Patch with ChangeLog
none
Patch with ChangeLog
none
debug build fix none

Iris Wu
Reported 2013-04-25 08:11:16 PDT
Currently the position smart scroll adjusts is the top left point of the viewport. On the page with fixed position elements, we want it to adjust the position beneath the fixed elements so it can be always visible.
Attachments
Patch with ChangeLog (6.25 KB, patch)
2013-04-25 08:36 PDT, Iris Wu 		no flags
DetailsFormatted DiffDiff
Patch with ChangeLog (7.25 KB, patch)
2013-04-25 11:08 PDT, Iris Wu 		no flags
DetailsFormatted DiffDiff
Patch with ChangeLog (7.23 KB, patch)
2013-04-25 11:13 PDT, Iris Wu 		no flags
DetailsFormatted DiffDiff
debug build fix (1.95 KB, patch)
2013-04-26 07:46 PDT, Iris Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Iris Wu
Comment 1 2013-04-25 08:36:59 PDT
Created attachment 199664 [details] Patch with ChangeLog
Rob Buis
Comment 2 2013-04-25 09:01:29 PDT
Comment on attachment 199664 [details] Patch with ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=199664&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:5255 > +void WebPage::findFixedElementRect(LayerCompositingThread* layer, Platform::IntRect& fixedElementRect) It seems like this method should be on LayerCompositingThread, since every operation uses layer.
Arvid Nilsson
Comment 3 2013-04-25 09:27:16 PDT
(In reply to comment #2) > (From update of attachment 199664 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199664&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:5255 > > +void WebPage::findFixedElementRect(LayerCompositingThread* layer, Platform::IntRect& fixedElementRect) > > It seems like this method should be on LayerCompositingThread, since every operation uses layer. I was thinking of suggesting to put this method on WebPageCompositorPrivate, at least. Maybe moving it to LayerCompositingThread makes even more sense - but I think traversing the layers should be the responsibility of some managing class like LayerRenderer or WebPageCompositor(Private), not LayerCompositingThread itself.
Iris Wu
Comment 4 2013-04-25 11:08:00 PDT
Created attachment 199689 [details] Patch with ChangeLog
WebKit Commit Bot
Comment 5 2013-04-25 11:09:51 PDT
Attachment 199689 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage.h', u'Source/WebKit/blackberry/Api/WebPageCompositor.cpp', u'Source/WebKit/blackberry/Api/WebPageCompositor_p.h', u'Source/WebKit/blackberry/ChangeLog']" exit_code: 1 Source/WebKit/blackberry/Api/WebPageCompositor_p.h:107: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Iris Wu
Comment 6 2013-04-25 11:13:00 PDT
Created attachment 199693 [details] Patch with ChangeLog
Rob Buis
Comment 7 2013-04-25 11:22:49 PDT
Comment on attachment 199693 [details] Patch with ChangeLog LGTM.
WebKit Commit Bot
Comment 8 2013-04-25 13:01:50 PDT
Comment on attachment 199693 [details] Patch with ChangeLog Clearing flags on attachment: 199693 Committed r149137: <http://trac.webkit.org/changeset/149137>
WebKit Commit Bot
Comment 9 2013-04-25 13:01:52 PDT
All reviewed patches have been landed. Closing bug.
Iris Wu
Comment 10 2013-04-26 07:46:12 PDT
Created attachment 199835 [details] debug build fix
Iris Wu
Comment 11 2013-04-30 15:27:16 PDT
New patch added
Rob Buis
Comment 12 2013-05-02 08:09:48 PDT
Comment on attachment 199835 [details] debug build fix Ok.
WebKit Commit Bot
Comment 13 2013-05-02 08:51:43 PDT
Comment on attachment 199835 [details] debug build fix Clearing flags on attachment: 199835 Committed r149487: <http://trac.webkit.org/changeset/149487>
WebKit Commit Bot
Comment 14 2013-05-02 08:51:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.