Summary: | [BlackBerry] Make scroll position adjustment work with pages with fixed position elements | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Iris Wu <shuwu> | ||||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | anilsson, commit-queue, rwlbuis | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Iris Wu
2013-04-25 08:11:16 PDT
Created attachment 199664 [details]
Patch with ChangeLog
Comment on attachment 199664 [details] Patch with ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=199664&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:5255 > +void WebPage::findFixedElementRect(LayerCompositingThread* layer, Platform::IntRect& fixedElementRect) It seems like this method should be on LayerCompositingThread, since every operation uses layer. (In reply to comment #2) > (From update of attachment 199664 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199664&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:5255 > > +void WebPage::findFixedElementRect(LayerCompositingThread* layer, Platform::IntRect& fixedElementRect) > > It seems like this method should be on LayerCompositingThread, since every operation uses layer. I was thinking of suggesting to put this method on WebPageCompositorPrivate, at least. Maybe moving it to LayerCompositingThread makes even more sense - but I think traversing the layers should be the responsibility of some managing class like LayerRenderer or WebPageCompositor(Private), not LayerCompositingThread itself. Created attachment 199689 [details]
Patch with ChangeLog
Attachment 199689 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage.h', u'Source/WebKit/blackberry/Api/WebPageCompositor.cpp', u'Source/WebKit/blackberry/Api/WebPageCompositor_p.h', u'Source/WebKit/blackberry/ChangeLog']" exit_code: 1
Source/WebKit/blackberry/Api/WebPageCompositor_p.h:107: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 199693 [details]
Patch with ChangeLog
Comment on attachment 199693 [details]
Patch with ChangeLog
LGTM.
Comment on attachment 199693 [details] Patch with ChangeLog Clearing flags on attachment: 199693 Committed r149137: <http://trac.webkit.org/changeset/149137> All reviewed patches have been landed. Closing bug. Created attachment 199835 [details]
debug build fix
New patch added Comment on attachment 199835 [details]
debug build fix
Ok.
Comment on attachment 199835 [details] debug build fix Clearing flags on attachment: 199835 Committed r149487: <http://trac.webkit.org/changeset/149487> All reviewed patches have been landed. Closing bug. |