Bug 115163

Summary: [GTK] Tools/gtk/install-dependencies is missing the ragel dependency
Product: WebKit Reporter: Xavi <xcastanho>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cgarcia, commit-queue, mrobinson, pnormand, rego, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Xavi
Reported 2013-04-25 01:49:15 PDT
harfbuzz requires ragel package to be installed.
Attachments
Patch (1.46 KB, patch)
2013-04-25 02:21 PDT, Xavi 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2013-04-25 02:49 PDT, Xavi 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2013-04-25 04:26 PDT, Xavi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xavi
Comment 1 2013-04-25 02:21:55 PDT
Created attachment 199640 [details] Patch
Xan Lopez
Comment 2 2013-04-25 02:36:33 PDT
Comment on attachment 199640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199640&action=review Maybe correct the name in the ChangeLog? A good way to learn about annoying reviewers ;) > Tools/ChangeLog:9 > + which is expected when building hardbuff Not very important, but the name is "harfbuzz".
Adrian Perez
Comment 3 2013-04-25 02:45:17 PDT
Informally reviewing... There is another small typo in the ChangeLog, please change “scrtip” to “script”. It would be nice to fix it when you edit the ChangeLog with Xan's comment. Apart from that, looks fine.
Xavi
Comment 4 2013-04-25 02:49:09 PDT
Created attachment 199644 [details] Patch
Xan Lopez
Comment 5 2013-04-25 03:06:51 PDT
Comment on attachment 199644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199644&action=review > Tools/ChangeLog:9 > + which is expected when building HarfBuff. Still wrong :D! See http://www.freedesktop.org/wiki/Software/HarfBuzz
Xavi
Comment 6 2013-04-25 04:26:16 PDT
Created attachment 199650 [details] Patch
WebKit Commit Bot
Comment 7 2013-04-25 07:18:34 PDT
Comment on attachment 199650 [details] Patch Clearing flags on attachment: 199650 Committed r149109: <http://trac.webkit.org/changeset/149109>
WebKit Commit Bot
Comment 8 2013-04-25 07:18:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.