Bug 115159

Summary: Fixing invalid block recovery in some declaration list.
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, kling, koivisto, macpherson, menard, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115157    
Attachments:
Description Flags
Patch
none
Patch none

Ryosuke Niwa
Reported 2013-04-25 01:09:54 PDT
We should consider merging https://chromium.googlesource.com/chromium/blink/+/e1034d760dc998bea13fc2691eaf1e04f78950e0 Fixing invalid block recovery in some delcaration list. Current grammar fails on tests 8, 12, 13, 15, 16, 17. This patch fixes it. It leds to further refactoring: introducing the rule 'decl_error: error | errors invalid_block_list error;' allows to lets to remove 3 rules reducing code duplication.
Attachments
Patch (6.56 KB, patch)
2013-05-23 11:33 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (6.68 KB, patch)
2013-05-24 04:22 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-05-23 11:33:46 PDT
Created attachment 202731 [details] Patch
Sergio Villar Senin
Comment 2 2013-05-23 11:34:38 PDT
Just touched a bit the test (added a description and removed an unused rule) from the original change.
Sergio Villar Senin
Comment 3 2013-05-24 04:22:09 PDT
Created attachment 202802 [details] Patch
Sergio Villar Senin
Comment 4 2013-05-24 04:22:44 PDT
(In reply to comment #3) > Created an attachment (id=202802) [details] > Patch The blink revision was wrong in the ChangeLog message. Also improved a bit the change description.
Sergio Villar Senin
Comment 5 2013-05-24 04:23:08 PDT
Some extra info about the change: https://docs.google.com/document/d/1e9D-ZqWEEw7TD1X-fqpo_18nuSMVsTK_V2xegAEj5X0/edit?usp=sharing&pli=1
WebKit Commit Bot
Comment 6 2013-05-24 17:49:19 PDT
Comment on attachment 202802 [details] Patch Clearing flags on attachment: 202802 Committed r150672: <http://trac.webkit.org/changeset/150672>
WebKit Commit Bot
Comment 7 2013-05-24 17:49:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.