Bug 115157 - Reducing CSS code duplication in declaration list error recovery
Summary: Reducing CSS code duplication in declaration list error recovery
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
Depends on: 115159
Blocks: 113401
  Show dependency treegraph
 
Reported: 2013-04-25 00:59 PDT by Ryosuke Niwa
Modified: 2013-05-25 01:29 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2013-05-24 07:25 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-25 00:59:41 PDT
We might want to consider importing

https://chromium.googlesource.com/chromium/blink/+/7e63c2b023715d1cdf2a283d0057eb41da144876
Reducing CSS code duplication in declaration list error recovery.
Comment 1 Sergio Villar Senin 2013-05-24 07:25:37 PDT
Created attachment 202817 [details]
Patch
Comment 2 Sergio Villar Senin 2013-05-24 07:27:00 PDT
Comment on attachment 202817 [details]
Patch

Removing the r? flag in order not to send this to the EWS as the patch does not apply without the patch for bug 115159
Comment 3 Sergio Villar Senin 2013-05-25 01:07:11 PDT
Comment on attachment 202817 [details]
Patch

Setting this for review now that 115159 landed
Comment 4 Andreas Kling 2013-05-25 01:27:20 PDT
Comment on attachment 202817 [details]
Patch

r=me. Happy to see this monster shrink a bit.
Comment 5 Sergio Villar Senin 2013-05-25 01:29:28 PDT
Comment on attachment 202817 [details]
Patch

Clearing flags on attachment: 202817

Committed r150682: <http://trac.webkit.org/changeset/150682>
Comment 6 Sergio Villar Senin 2013-05-25 01:29:35 PDT
All reviewed patches have been landed.  Closing bug.