Bug 115157

Summary: Reducing CSS code duplication in declaration list error recovery
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, glenn, kling, koivisto, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115159    
Bug Blocks: 113401    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2013-04-25 00:59:41 PDT
We might want to consider importing https://chromium.googlesource.com/chromium/blink/+/7e63c2b023715d1cdf2a283d0057eb41da144876 Reducing CSS code duplication in declaration list error recovery.
Attachments
Patch (3.06 KB, patch)
2013-05-24 07:25 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-05-24 07:25:37 PDT
Created attachment 202817 [details] Patch
Sergio Villar Senin
Comment 2 2013-05-24 07:27:00 PDT
Comment on attachment 202817 [details] Patch Removing the r? flag in order not to send this to the EWS as the patch does not apply without the patch for bug 115159
Sergio Villar Senin
Comment 3 2013-05-25 01:07:11 PDT
Comment on attachment 202817 [details] Patch Setting this for review now that 115159 landed
Andreas Kling
Comment 4 2013-05-25 01:27:20 PDT
Comment on attachment 202817 [details] Patch r=me. Happy to see this monster shrink a bit.
Sergio Villar Senin
Comment 5 2013-05-25 01:29:28 PDT
Comment on attachment 202817 [details] Patch Clearing flags on attachment: 202817 Committed r150682: <http://trac.webkit.org/changeset/150682>
Sergio Villar Senin
Comment 6 2013-05-25 01:29:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.