Bug 115155

Summary: Delete maketokenizer
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, evab.u-szeged, glenn, gyuyoung.kim, jchaffraix, koivisto, macpherson, menard, oliver, zherczeg
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryosuke Niwa
Reported 2013-04-25 00:52:12 PDT
https://chromium.googlesource.com/chromium/blink/+/2a1c8aaf867f707ccdcd8893446e907e2aa2e1c2 This script was used to generate the old flex based CSS tokenizer. It was replaced by a custom tokenizer in r106217 but the script wasn't removed. Since there is no mention of it in the original bug nor any reference to maketokenizer in our build files, it's probably an oversight.
Attachments
Patch (5.71 KB, patch)
2013-11-05 06:45 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2013-11-05 07:31 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-11-05 06:30:06 PST
*** Bug 123801 has been marked as a duplicate of this bug. ***
Éva Balázsfalvi
Comment 2 2013-11-05 06:45:48 PST
Created attachment 216033 [details] Patch
Éva Balázsfalvi
Comment 3 2013-11-05 07:31:38 PST
Created attachment 216037 [details] Patch
Zoltan Herczeg
Comment 4 2013-11-05 07:40:46 PST
Comment on attachment 216037 [details] Patch Nice! rs=me
WebKit Commit Bot
Comment 5 2013-11-05 08:04:24 PST
Comment on attachment 216037 [details] Patch Clearing flags on attachment: 216037 Committed r158673: <http://trac.webkit.org/changeset/158673>
WebKit Commit Bot
Comment 6 2013-11-05 08:04:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.