Summary: | Add support for Math.imul | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, rniwa, syoichi | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Oliver Hunt
2013-04-24 18:00:22 PDT
Created attachment 199571 [details]
Patch
Comment on attachment 199571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199571&action=review I think FixupPhase is borked - it should call the fixIntEdge() thingy. > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:215 > + setUseKindAndUnboxIfProfitable<Int32Use>(node->child1()); > + setUseKindAndUnboxIfProfitable<Int32Use>(node->child2()); Why doesn't this call fixIntEdge() instead, like the bit ops do? Created attachment 199608 [details]
Patch
Attachment 199608 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/Object-getOwnPropertyNames-expected.txt', u'LayoutTests/fast/js/imul.html', u'LayoutTests/fast/js/regress/imul-double-only-expected.txt', u'LayoutTests/fast/js/regress/imul-double-only.html', u'LayoutTests/fast/js/regress/imul-int-only-expected.txt', u'LayoutTests/fast/js/regress/imul-int-only.html', u'LayoutTests/fast/js/regress/imul-mixed-expected.txt', u'LayoutTests/fast/js/regress/imul-mixed.html', u'LayoutTests/fast/js/regress/script-tests/imul-double-only.js', u'LayoutTests/fast/js/regress/script-tests/imul-int-only.js', u'LayoutTests/fast/js/regress/script-tests/imul-mixed.js', u'LayoutTests/fast/js/script-tests/Object-getOwnPropertyNames.js', u'LayoutTests/fast/js/script-tests/imul.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/create_hash_table', u'Source/JavaScriptCore/dfg/DFGAbstractState.cpp', u'Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCSEPhase.cpp', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp', u'Source/JavaScriptCore/jit/ThunkGenerators.h', u'Source/JavaScriptCore/runtime/Intrinsic.h', u'Source/JavaScriptCore/runtime/MathObject.cpp', u'Source/JavaScriptCore/runtime/VM.cpp']" exit_code: 1
LayoutTests/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 199608 [details] Patch Attachment 199608 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/26810 New failing tests: fast/js/regress/imul-mixed.html fast/js/imul.html Created attachment 199618 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment on attachment 199608 [details] Patch Attachment 199608 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/191170 New failing tests: fast/js/regress/imul-mixed.html fast/js/imul.html Created attachment 199635 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Created attachment 199768 [details]
Patch
Committed r149159: <http://trac.webkit.org/changeset/149159> |