Summary: | Permit ~/Library to be a symlink | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Cooper <scooper> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, scooper | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Cooper
2013-04-24 17:57:12 PDT
Created attachment 199570 [details]
Patch
Comment on attachment 199570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199570&action=review Looks good to me, with a question about pwd.pw_dir encoding below. Note however that this behavior doesn't quite match AppSandbox, which also allows ~/Library/Preferences to be a symlink. > Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:18 > +(define (home-library-regex home-library-relative-regex) > + (regex (string-append "^" (regex-quote (param "HOME_LIBRARY_DIR")) home-library-relative-regex))) Indentation should be 4 characters here, too. > Source/WebKit2/Shared/mac/ChildProcessMac.mm:142 > + String libraryPath = String(pwd.pw_dir); This constructor treats the input as Latin-1. Is this correct, or should it be UTF-8? In the latter case, String::fromUTF8() is the right way to create the String object. Created attachment 199861 [details]
Patch
Updated the patch to support both ~/Library and ~/Library/Preferences. Made sure that a home directory containing unicode makes it to the Sandboxing without being mangled. Comment on attachment 199861 [details]
Patch
Commit queue won't land this patch because of spaces. I'll land manually.
Committed <http://trac.webkit.org/r149217>. |