Bug 115118

Summary: [GTK] Use stamp files for generate-forwarding-headers makefile rules
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch mrobinson: review+

Carlos Garcia Campos
Reported 2013-04-24 10:36:23 PDT
We are currently running the generate-forwarding-headers.pl script 6 times everytime we run make even if nothing has changed. This is because the makefile rules that call the script don't create a file that can be checked to decide whether to run the rule or not.
Attachments
Patch (5.37 KB, patch)
2013-04-24 10:43 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (4.95 KB, patch)
2013-04-24 11:26 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-04-24 10:43:15 PDT
Created attachment 199499 [details] Patch
Martin Robinson
Comment 2 2013-04-24 11:12:38 PDT
Comment on attachment 199499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199499&action=review Looks good. I just have one question... > Source/WebKit2/GNUmakefile.am:326 > BUILT_SOURCES += generate-webkit2-forwarding-headers Would it make more sense to add the stamp files to BUILT_SOURCES now? > Tools/TestWebKitAPI/GNUmakefile.am:229 > +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES) I don't think there's any need for this intermediate variable, unless it's used somewhere else.
Carlos Garcia Campos
Comment 3 2013-04-24 11:18:52 PDT
(In reply to comment #2) > (From update of attachment 199499 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=199499&action=review > > Looks good. I just have one question... > > > Source/WebKit2/GNUmakefile.am:326 > > BUILT_SOURCES += generate-webkit2-forwarding-headers > > Would it make more sense to add the stamp files to BUILT_SOURCES now? hmm, I think you are right, and we don't need to add them to cleanfiles either since all built source are already in cleanfiles. Let me try. > > Tools/TestWebKitAPI/GNUmakefile.am:229 > > +wk2_tests_sources = $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES) > > I don't think there's any need for this intermediate variable, unless it's used somewhere else. It makes the rule easier to read, that's all.
Carlos Garcia Campos
Comment 4 2013-04-24 11:26:29 PDT
Created attachment 199505 [details] Updated patch Removed intermediate rules
Martin Robinson
Comment 5 2013-04-24 11:27:26 PDT
Comment on attachment 199505 [details] Updated patch Thanks!
Carlos Garcia Campos
Comment 6 2013-04-24 11:33:17 PDT
Committed r149052: <http://trac.webkit.org/changeset/149052>
Note You need to log in before you can comment on or make changes to this bug.