Bug 115114
| Summary: | ref-tests should compare the entire page instead of the viewport | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | benjamin, bjonesbe, glenn, jberlin, rniwa, simon.fraser, thorton |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Zoltan Horvath
The topic was discussed in https://lists.webkit.org/pipermail/webkit-dev/2013-April/024766.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Glenn Adams
if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage
Ryosuke Niwa
(In reply to comment #1)
> if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage
We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all.
Glenn Adams
(In reply to comment #2)
> (In reply to comment #1)
> > if existing reftests assume that only a particular (e.g., 800x600) area is compared, then we should not change the default to compare the entire page; that is, comparing the entire page should be opt-in due to prior usage
>
> We shouldn’t make such assumptions in reftests. If there are ref tests that make such a bad assumption, then we should fix them all.
ok, in that case, the documentations about creating reftests [1] should make this explicit; authors may have assumed that 800x600 holds due to the language in [2]
[1] http://trac.webkit.org/wiki/Writing%20Reftests
[2] http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Howtowriteportablepixeltests